test: Add TestNode wait_until helper #29029

issue maflcko openend this issue on December 8, 2023
  1. maflcko commented at 11:51 am on December 8, 2023: member

    Motivation

    Currently, inside TestNode, the global wait_until_helper_internal must be used, and each time the timeout factor must be passed.

    See #29006 (review)

    Possible solution

    It would be nice to have a method wait_until that wraps the wait_until_helper_internal call, like in other classes.

    Useful Skills

    • Compiling Bitcoin Core from source
    • Running the C++ unit tests and the Python functional tests
    • Python 3

    Guidance for new contributors

    Want to work on this issue?

    For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

  2. maflcko added the label good first issue on Dec 8, 2023
  3. maflcko added the label Tests on Dec 8, 2023
  4. nikodemas commented at 2:44 pm on December 8, 2023: contributor
    Hi, I would like to work on this
  5. mohamedawnallah commented at 5:05 pm on December 12, 2023: none
    Hey, @nikodemas Are you still working on this issue? If not I’d like to pick it up. Thanks
  6. nikodemas commented at 8:07 am on December 13, 2023: contributor
    Hi @mohamedawnallah , still working :)
  7. achow101 closed this on Dec 14, 2023

  8. denavila referenced this in commit 9860471708 on Jan 26, 2024
  9. bitcoin locked this on Dec 13, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-21 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me