Add a note to msvc readme re building Qt for Bitcoin Core. #29048

1. 
   sipsorcery commented at 2:09 pm on December 10, 2023: contributor

   Updated the msvc readme with a note about avoiding path too long errors when building Qt with Bitcoin Core.

   Would have saved me half an hour if I’d remembered this from the last time I did the build.

2. 
   DrahtBot commented at 2:09 pm on December 10, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. hebasto approved
4. 
   hebasto commented at 2:13 pm on December 10, 2023: member

   ACK a9b9fb2eeedbd9094d74f8f429622ba7d600dda3, the tip is correct and useful.

   However, it won’t be needed after migration to CMake as vcpkg’s Qt package will be used then.

5. 
   hebasto commented at 2:14 pm on December 10, 2023: member

   @sipsorcery

   There is a linter error in CI:

   0File "build_msvc/README.md" has permission 755 (executable) and is thus expected to contain a shebang '#!'. Add shebang or do "chmod 644 build_msvc/README.md" to make it non-executable.
   

6. DrahtBot added the label CI failed on Dec 10, 2023
7. 
   sipsorcery commented at 3:30 pm on December 10, 2023: contributor

   @sipsorcery

   There is a linter error in CI:

   Even after I manually checked for whitespace violations on that single line addition :(.

   Although it does seem like the linter culprit may be elsewhere? Or, am I missing something?

   0src/test/fuzz/package_eval.cpp:214: non-existant ==> non-existent
   1src/test/span_tests.cpp:56: memeber ==> member
   2^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
   3File "build_msvc/README.md" has permission 755 (executable) and is thus expected to contain a shebang '#!'. Add shebang or do "chmod 644 build_msvc/README.md" to make it non-executable.
   4ERROR: There were 1 failed tests in the lint-files.py lint test. Please resolve the above errors.
   5^---- failure generated from lint-files.py
   

8. 
   hebasto commented at 3:37 pm on December 10, 2023: member

   Or, am I missing something?

   Just rewording the linter:

   The problem is:

   0$ stat build_msvc/README.md 
   1  File: build_msvc/README.md
   2  Size: 5650      	Blocks: 16         IO Block: 4096   regular file
   3Device: 10303h/66307d	Inode: 14949723    Links: 1
   4Access: (0755/-rwxr-xr-x)  Uid: ( 1001/ hebasto)   Gid: ( 1001/ hebasto)
   5Access: 2023-12-10 15:34:07.780145234 +0000
   6Modify: 2023-12-10 15:34:06.520175365 +0000
   7Change: 2023-12-10 15:34:06.520175365 +0000
   8 Birth: 2023-12-10 15:34:06.520175365 +0000
   

   The fix is:

   0$ chmod 644 build_msvc/README.md
   

   (the POSIX environment is assumed)

9. 
   hebasto commented at 3:45 pm on December 10, 2023: member

   @sipsorcery

   We make such changes in a single commit usually :)

   Mind squashing your commits?

10. Add a note to msvc readme re building Qt for Bitcoin Core. d08e820abf
11. sipsorcery force-pushed on Dec 10, 2023
12. hebasto approved
13. 
    hebasto commented at 3:55 pm on December 10, 2023: member

    ACK d08e820abf5da2be09b8a84b5bd3450d1a55a039.
14. DrahtBot removed the label CI failed on Dec 10, 2023
15. TheCharlatan approved
16. 
    TheCharlatan commented at 8:29 pm on December 10, 2023: contributor

    ACK d08e820abf5da2be09b8a84b5bd3450d1a55a039
17. fanquake merged this on Dec 11, 2023
18. fanquake closed this on Dec 11, 2023

    ---

19. bitcoin locked this on Dec 10, 2024

Contributors
sipsorcery DrahtBot hebasto TheCharlatan