bumpfee doc about incrementalfee is incorrect #29053

1. 
   kallerosenbaum commented at 11:19 am on December 11, 2023: none

   Is there an existing issue for this?

   • I have searched the existing issues

   Current behaviour

   The documentation for the bumpfee command states

   “At a minimum, the new fee rate must be high enough to pay an additional new relay fee (incrementalfee
   returned by getnetworkinfo) to enter the node’s mempool.”

   While not strictly incorrect (the “At a minimum” part), it is very misleading.

   Expected behaviour

   It should read something like “At a minimum, the new fee rate must be high enough to pay an additional new relay fee (5 sats/vB) to enter the node’s mempool.”

   because the wallet uses WALLET_INCREMENTAL_RELAY_FEE which is 5 sats/vB by default.

   Alternatively use the DEFAULT_INCREMENTAL_RELAY_FEE when fee_rate is set as suggested by @Sjors here: #26973

   Steps to reproduce

   bitcoin-cli help bumpfee

   See also stackexchange: https://bitcoin.stackexchange.com/questions/120887/why-wont-bumpfee-accept-my-new-fee-rate

   Relevant log output

   No response

   How did you obtain Bitcoin Core

   Pre-built binaries

   What version of Bitcoin Core are you using?

   25.0 and 26.0

   Operating system and version

   debian 12

   Machine specifications

   No response

2. 
   maflcko commented at 3:23 pm on December 11, 2023: member

   Both need to be satisfied, whichever is higher will then take precedence, no?
3. maflcko added the label Docs on Dec 11, 2023
4. maflcko added the label RPC/REST/ZMQ on Dec 11, 2023
5. 
   maflcko commented at 1:50 pm on December 12, 2023: member

   Pull requests with improvements are welcome :)
6. 
   ismaelsadeeq commented at 11:25 am on March 1, 2024: member

   Pull requests with improvements are welcome :)

   There is a PR opened that goes with the second approach of using DEFAULT_INCREMENTAL_RELAY_FEE when fee_rate is set as suggested by @Sjors here: #26973

   People interested in this can look at #27969

7. 
   ismaelsadeeq commented at 3:19 pm on June 18, 2024: member

   Alternatively use the DEFAULT_INCREMENTAL_RELAY_FEE when fee_rate is set as suggested by @Sjors here: #26973

   #27969 was merged, this can be closed?

8. maflcko closed this on Jun 18, 2024

   ---

Contributors
kallerosenbaum maflcko ismaelsadeeq

Labels
Docs RPC/REST/ZMQ