build: GCC 10.5 fails to compile test_bitcoin using Boost.Test 1.71 #29063

1. 
   hebasto commented at 4:34 pm on December 12, 2023: member

   On fresh Ubuntu 20.04, with dependencies installed via apt:

    0$ ./configure CC=gcc-10 CXX=g++-10
    1$ make -C src test/test_bitcoin
    2make: Entering directory '/bitcoin/src'
    3  CXX      test/test_bitcoin-main.o
    4In file included from /usr/include/boost/test/included/unit_test.hpp:29,
    5                 from test/main.cpp:10:
    6/usr/include/boost/test/impl/test_tools.ipp: In member function 'void boost::test_tools::tt_detail::print_log_value<const wchar_t*>::operator()(std::ostream&, const wchar_t*)':
    7/usr/include/boost/test/impl/test_tools.ipp:127:38: error: use of deleted function 'std::basic_ostream<char, _Traits>& std::operator<<(std::basic_ostream<char, _Traits>&, const wchar_t*) [with _Traits = std::char_traits<char>]'
    8  127 |     ostr << ( t ? t : L"null string" );
    9      |                                      ^
   10In file included from /usr/include/c++/10/iostream:39,
   11                 from /usr/include/boost/test/unit_test_log_formatter.hpp:26,
   12                 from /usr/include/boost/test/output/compiler_log_formatter.hpp:17,
   13                 from /usr/include/boost/test/impl/compiler_log_formatter.ipp:19,
   14                 from /usr/include/boost/test/included/unit_test.hpp:18,
   15                 from test/main.cpp:10:
   16/usr/include/c++/10/ostream:634:5: note: declared here
   17  634 |     operator<<(basic_ostream<char, _Traits>&, const wchar_t*) = delete;
   18      |     ^~~~~~~~
   19make: *** [Makefile:18328: test/test_bitcoin-main.o] Error 1
   20make: Leaving directory '/bitcoin/src'
   

2. hebasto added the label Build system on Dec 12, 2023
3. 
   hebasto commented at 4:38 pm on December 12, 2023: member

   Quick googling shows:

   • upstream bug – https://github.com/boostorg/test/issues/249
   • upstream fix – https://github.com/boostorg/test/pull/252

   Should we update the minimum support Boost version then?

4. 
   maflcko commented at 4:46 pm on December 12, 2023: member

   Should we update the minimum support Boost version then?

   Sounds good. I don’t see an alternative.

5. 
   hebasto commented at 4:47 pm on December 12, 2023: member

   Should we update the minimum support Boost version then?

   Sounds good. I don’t see an alternative.

   Going to do more thorough tests before submitting a PR.

6. maflcko added this to the milestone 27.0 on Dec 12, 2023
7. maflcko added the label Tests on Dec 12, 2023
8. 
   hebasto commented at 6:29 pm on December 12, 2023: member

   Going to do more thorough tests before submitting a PR.

   Found one more fixed bug. See #29066.

9. fanquake closed this on Dec 13, 2023

   ---

10. fanquake referenced this in commit 0830dcb313 on Dec 13, 2023

Contributors
hebasto maflcko

Labels
Build system Tests

Milestone
27.0