Fix spelling errors #29107

pull kristapsk wants to merge 1 commits into bitcoin:master from kristapsk:fix-spelling changing 3 files +3 −2

kristapsk commented at 1:16 PM on December 18, 2023: contributor

Found these when running lint tests locally.

src/rpc/util.h:405: falsy ==> falsely, false
src/rpc/util.h:408: falsy ==> falsely, false
src/test/fuzz/package_eval.cpp:214: non-existant ==> non-existent
src/test/span_tests.cpp:56: memeber ==> member
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt

Guess it's because I'm having different version of codespell?

In any case, these aren't false positives and should be fixed.

Fix spelling errors 4f8118238f
DrahtBot commented at 1:16 PM on December 18, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
brunoerg commented at 3:57 PM on December 18, 2023: contributor

You could include this one (not detected by linter): https://github.com/bitcoin/bitcoin/blob/dd391944dc2d4e7dda9439647e603b41ba751b78/src/wallet/fees.cpp#L52
glozow commented at 4:02 PM on December 18, 2023: member

You could include this one (not detected by linter):

iff is an abbreviation of "if and only if"

in src/test/fuzz/package_eval.cpp:214 in 4f8118238f

 210 | @@ -211,7 +211,7 @@ FUZZ_TARGET(tx_package_eval, .init = initialize_tx_pool)
 211 |                      tx_mut.vin.push_back(tx_mut.vin.back());
 212 |                  }
 213 |  
 214 | -                // Refer to a non-existant input
 215 | +                // Refer to a non-existent input

glozow commented at 4:03 PM on December 18, 2023:

this is done in #28948

brunoerg commented at 4:07 PM on December 18, 2023: contributor

iff is an abbreviation of "if and only if"

didn't know it, thanks! :)
glozow commented at 11:21 AM on December 21, 2023: member

I'm going to close this in an effort focus review attention on more important PRs, sorry (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#pull-request-philosophy). I think it makes more sense to fix typos as we work on those areas of code.
glozow closed this on Dec 21, 2023
kristapsk commented at 12:01 PM on December 21, 2023: contributor

IMHO it would have been simpler to just merge such trivial changes, but ok.
kristapsk deleted the branch on Dec 21, 2023
bitcoin locked this on Dec 20, 2024

Contributors

Fix spelling errors #29107

Code Coverage

Reviews