Possibly due to a silent cross-merge, scanblocks was left out of 96233146dd31c1d99fd1619be4449944623ef750
RPC/Blockchain: scanblocks: Accept named param for filter_false_positives #29184
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:rpc_scanblocks_ffp_named changing 2 files +2 −1-
luke-jr commented at 9:21 PM on January 4, 2024: member
-
DrahtBot commented at 9:21 PM on January 4, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK stickies-v, theStack If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
RPC/Blockchain: scanblocks: Accept named param for filter_false_positives 5779010ed7
- luke-jr force-pushed on Jan 4, 2024
- stickies-v approved
-
stickies-v commented at 5:43 PM on January 5, 2024: contributor
ACK 5779010ed7be1cbe9b98a91c7487d3d14b7cf24d
Also quickly checked that all other options objects properly accept named parameters (although I didn't check every single options parameter)
- theStack approved
-
theStack commented at 2:30 PM on January 7, 2024: contributor
ACK 5779010ed7be1cbe9b98a91c7487d3d14b7cf24d
- glozow assigned glozow on Jan 8, 2024
- glozow merged this on Jan 8, 2024
- glozow closed this on Jan 8, 2024
- glozow added the label RPC/REST/ZMQ on Jan 8, 2024
- glozow unassigned glozow on Jan 8, 2024
- bitcoin locked this on Jan 7, 2025
Contributors
Labels