RPC/Blockchain: scanblocks: Accept named param for filter_false_positives #29184

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:rpc_scanblocks_ffp_named changing 2 files +2 −1
  1. luke-jr commented at 9:21 pm on January 4, 2024: member
    Possibly due to a silent cross-merge, scanblocks was left out of 96233146dd31c1d99fd1619be4449944623ef750
  2. DrahtBot commented at 9:21 pm on January 4, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK stickies-v, theStack

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. RPC/Blockchain: scanblocks: Accept named param for filter_false_positives 5779010ed7
  4. luke-jr force-pushed on Jan 4, 2024
  5. stickies-v approved
  6. stickies-v commented at 5:43 pm on January 5, 2024: contributor

    ACK 5779010ed7be1cbe9b98a91c7487d3d14b7cf24d

    Also quickly checked that all other options objects properly accept named parameters (although I didn’t check every single options parameter)

  7. theStack approved
  8. theStack commented at 2:30 pm on January 7, 2024: contributor
    ACK 5779010ed7be1cbe9b98a91c7487d3d14b7cf24d
  9. glozow assigned glozow on Jan 8, 2024
  10. glozow merged this on Jan 8, 2024
  11. glozow closed this on Jan 8, 2024

  12. glozow added the label RPC/REST/ZMQ on Jan 8, 2024
  13. glozow unassigned glozow on Jan 8, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-29 07:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me