Enable maxfeerate and maxburnamount as startup config options. #29217

1. 
   ismaelsadeeq commented at 10:48 am on January 10, 2024: member

   Please describe the feature you’d like to see added.

   maxfeerate is a sanity check optional parameter used by clients to ensure transactions submitted to the mempool and relayed to the network by a node withsendrawtransaction, testmempoolaccept and now possibly submitpackage #28950 does not exceed the maxfeerate value. Node will reject transactions whose fee rate is higher than maxfeerate.

   maxburnamount is also a sanity check optional parameter used by sendrawtransaction now possibly submitpackage #28950 to reject all transactions with OP_RETURN outputs greater than the maxburnamount.

   ---

   Should we enable passing maxburnamount and maxfeerate as startup-config options to be used by those RPC calls instead?

   Is your feature related to a problem, if so please describe it.

   Requested here #28950 (review)

   Describe the solution you’d like

   Add startup config options maxfeerate, and maxburnamount as a sanity check for transactions entering the mempool and relayed to the network.

   Describe any alternatives you’ve considered

   No response

   Please leave any additional context

   No response

2. ismaelsadeeq added the label Feature on Jan 10, 2024
3. bitcoin deleted a comment on Jan 11, 2024
4. 
   glozow commented at 3:02 pm on January 19, 2024: member

   fwiw I’m concept -0 on adding a global maxburnamount option. I think it’s less footgunny for the default to always be 0 and for users specify explicitly each time they want to burn money. But if people really want this then ok.
5. 
   ismaelsadeeq commented at 4:11 pm on January 19, 2024: member

   Closing this, after @glozow feedback here #29278 (review)
6. ismaelsadeeq closed this on Jan 19, 2024

   ---

Contributors
ismaelsadeeq glozow

Labels
Feature