This exposes CNode::addrLocal to the user, formatted as a string, just like the existing "addr" field. I named it "peerlocal" instead of "addrlocal" to avoid breaking scripts that grep on the word "addr". Interestingly, the addrLocal structure isn't filled in properly in all cases (I have seen IPv6 nodes connect to my bitcoind but addrLocal contains only my IPv4 address), but at least this gives it exposure to aid in fixing this deeper bug that lies elsewhere in bitcoind.
Added new peerlocal field to RPC getpeerinfo per-node output #2923
pull Krellan wants to merge 2 commits into bitcoin:master from Krellan:master changing 6 files +93 −5-
Krellan commented at 5:56 AM on August 22, 2013: contributor
-
Added new peerlocal field to RPC getpeerinfo per-node output, which comes from CNode::addrLocal. a505a99a08
-
BitcoinPullTester commented at 8:25 AM on August 22, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a505a99a08753fa3c3b890fc6222679539b2f64c for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
Ping time support. Added RPC ping command. Added pong handler. Added timing results to getpeerinfo. fbc91c10d8
-
BitcoinPullTester commented at 12:26 PM on August 22, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/fbc91c10d818432070ef8bac56b07707f43ef0b1 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
Krellan commented at 5:21 PM on August 22, 2013: contributor
Unfortunately, two different features got mangled together in the same pull request. My bad. Will close and resubmit separately.
- Krellan closed this on Aug 22, 2013
- IntegralTeam referenced this in commit 38aab0c5e3 on Jun 4, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors