depends: Ensure definitions are passed when building SQLite with `DEBUG=1` #29282

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240119-sqlite changing 1 files +3 −3

hebasto commented at 11:34 AM on January 19, 2024: member

The SQLite build system overrides the CFLAGS when is configured with the --enable-debug option.

Amends #25987.

Otherwise, for example in OSS-Fuzz, the testing binaries diverge from the release ones.

depends: Ensure definitions are passed when building SQLite with DEBUG=1

The SQLite build system overrides the `CFLAGS` when is configured with
the `--enable-debug` option.

e45f8f10bf

hebasto added the label Build system on Jan 19, 2024
DrahtBot commented at 11:34 AM on January 19, 2024: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #29287 (depends: Do not override CFLAGS when building SQLite with DEBUG=1 by hebasto)
- #27495 (ci: Use DEBUG=1 in depends for MSAN jobs by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
hebasto commented at 12:28 PM on January 25, 2024: member

Combined into #29287.

Closing.
hebasto closed this on Jan 25, 2024
fanquake referenced this in commit ac923e70e7 on Jan 25, 2024
hebasto deleted the branch on Jan 26, 2024
knst referenced this in commit 632ffb8388 on Aug 23, 2024
PastaPastaPasta referenced this in commit 1b88674815 on Sep 27, 2024
PastaPastaPasta referenced this in commit 1d02c15258 on Sep 27, 2024
bitcoin locked this on Jan 25, 2025

Contributors

Labels