Add missed `config/bitcoin-config.h` header #29333

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240127-config_h changing 1 files +4 −0

hebasto commented at 6:28 PM on January 27, 2024: member

The config/bitcoin-config.h header is required to provide definitions for the USE_BDB and USE_SQLITE macros.

While this header might be included indirectly elsewhere, including it explicitly makes the build process more robust.
DrahtBot commented at 6:28 PM on January 27, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Add missed `config/bitcoin-config.h` header

The `config/bitcoin-config.h` header is required to provide definitions
for the `USE_BDB` and `USE_SQLITE` macros.

35ccd500ad

hebasto force-pushed on Jan 27, 2024
in src/wallet/walletdb.cpp:12 in 35ccd500ad
```
   4 | @@ -5,6 +5,10 @@
   5 |  
   6 |  #include <wallet/walletdb.h>
   7 |  
   8 | +#if defined(HAVE_CONFIG_H)
   9 | +#include <config/bitcoin-config.h>
  10 | +#endif
  11 | +
  12 |  #include <common/system.h>
```
furszy commented at 6:49 PM on January 27, 2024:

Isn't bitcoin-config.h indirectly included by this system.h include? (which btw, doesn't seems to be needed).

hebasto commented at 6:51 PM on January 27, 2024:

Isn't bitcoin-config.h indirectly included by this system.h include?

It is.

While this header might be included indirectly elsewhere, including it explicitly makes the build process more robust.

furszy commented at 6:56 PM on January 27, 2024:

then it would be good to remove the unused include within this change. walletdb.cpp does not call to any system.h` function.
TheCharlatan commented at 9:26 PM on January 27, 2024: contributor

What motivates changing only this single file and not the various other modules that iwyu reports to have unused or missing bitcoin-config.h includes?
hebasto commented at 9:37 PM on January 27, 2024: member

What motivates changing only this single file and not the various other modules that iwyu reports to have unused or missing bitcoin-config.h includes?

It was spotted during debugging another issue. Agree that it looks like a random diff.
hebasto closed this on Jan 27, 2024
bitcoin locked this on Jan 26, 2025

Contributors

Add missed `config/bitcoin-config.h` header #29333

Code Coverage

Reviews