Document and test OP_RESERVED weirdness #2938

pull petertodd wants to merge 1 commits into bitcoin:master from petertodd:op-reserved-weirdness changing 5 files +18 −3

petertodd commented at 3:16 AM on August 25, 2013: contributor

Seems it was forgotten about when IsPushOnly() and the unittests were written. A particular oddity is that OP_RESERVED doesn't count towards the >201 opcode limit unlike every other named opcode.
BitcoinPullTester commented at 4:00 AM on August 25, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/81c04138fce10654f52c7ccab2ed349f0d5e3137 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 2:06 PM on August 25, 2013: member

ACK

Document and test OP_RESERVED weirdness

Seems it was forgotten about when IsPushOnly() and the unittests were
written. A particular oddity is that OP_RESERVED doesn't count towards
the >201 opcode limit unlike every other named opcode.

214d45b6b9

petertodd commented at 4:38 PM on August 25, 2013: contributor

Minor update: fixed two incorrect comments.
BitcoinPullTester commented at 5:32 PM on August 25, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/214d45b6b9a4f25d7d8bd4e5443fa2bee485353a for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
gavinandresen commented at 1:17 AM on August 26, 2013: contributor

ACK
gavinandresen referenced this in commit b62dc051aa on Aug 26, 2013
gavinandresen merged this on Aug 26, 2013
gavinandresen closed this on Aug 26, 2013
petertodd deleted the branch on Aug 26, 2013
DrahtBot locked this on Sep 8, 2021

Contributors