v3 followups #29424

1. 
   glozow commented at 2:33 pm on February 12, 2024: member

   Addresses final comments from #28948:

   • thread at #28948 (review), using https://github.com/ismaelsadeeq/bitcoin/commit/87fc7f0a8d8ad1fc2af60ee6cc678df5e6fb01dd with some modifications
   • #28948 (review)
   • #28948 (review)
   • #28948 (review)
   • #28948 (review)
   • #28948 (review)
   • #28948 (review)
   • #28948 (review)
   • #28948 (review)
2. [doc] fix docs and comments from v3 63b62e123e
3. glozow added the label Refactoring on Feb 12, 2024
4. glozow added the label Docs on Feb 12, 2024
5. glozow added the label Tests on Feb 12, 2024
6. 
   DrahtBot commented at 2:33 pm on February 12, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	instagibbs, sdaftuar

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28886 (refactor: Replace sets of txiter with CTxMemPoolEntryRefs by TheCharlatan)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. [test] PackageV3Checks with inheritance violation in mempool ancestor a9346421db
8. [refactor] use MAX_PUBKEYS_PER_MULTISIG instead of magic numbers in test 5c998a696c
9. glozow force-pushed on Feb 12, 2024
10. [test] second child of a v3 tx can be replaced individually

    Co-authored-by: ismaelsadeeq <ask4ismailsadiq@gmail.com>

    6b161cb82a
11. 
    instagibbs commented at 3:35 pm on February 12, 2024: member

    ACK 6b161cb82a9766ef814f05e5b8f019f15d5ee14d
12. 
    sdaftuar commented at 12:44 pm on February 13, 2024: member

    utACK 6b161cb82a9766ef814f05e5b8f019f15d5ee14d
13. fanquake merged this on Feb 13, 2024
14. fanquake closed this on Feb 13, 2024

    ---

15. glozow deleted the branch on Feb 13, 2024
16. bitcoin locked this on Feb 12, 2025

Contributors
glozow DrahtBot instagibbs sdaftuar

Labels
Refactoring Docs Tests