Addresses final comments from #28948:
v3 followups #29424
pull glozow wants to merge 4 commits into bitcoin:master from glozow:2024-02-v3-followups changing 6 files +44 −10-
glozow commented at 2:33 pm on February 12, 2024: member
-
[doc] fix docs and comments from v3 63b62e123e
-
glozow added the label Refactoring on Feb 12, 2024
-
glozow added the label Docs on Feb 12, 2024
-
glozow added the label Tests on Feb 12, 2024
-
DrahtBot commented at 2:33 pm on February 12, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage
For detailed information about the code coverage, see the test coverage report.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK instagibbs, sdaftuar If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #28886 (refactor: Replace sets of txiter with CTxMemPoolEntryRefs by TheCharlatan)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
[test] PackageV3Checks with inheritance violation in mempool ancestor a9346421db
-
[refactor] use MAX_PUBKEYS_PER_MULTISIG instead of magic numbers in test 5c998a696c
-
glozow force-pushed on Feb 12, 2024
-
[test] second child of a v3 tx can be replaced individually
Co-authored-by: ismaelsadeeq <ask4ismailsadiq@gmail.com>
-
instagibbs commented at 3:35 pm on February 12, 2024: memberACK 6b161cb82a9766ef814f05e5b8f019f15d5ee14d
-
sdaftuar commented at 12:44 pm on February 13, 2024: memberutACK 6b161cb82a9766ef814f05e5b8f019f15d5ee14d
-
fanquake merged this on Feb 13, 2024
-
fanquake closed this on Feb 13, 2024
-
glozow deleted the branch on Feb 13, 2024
glozow
DrahtBot
instagibbs
sdaftuar
Labels
Refactoring
Docs
Tests
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:12 UTC
More mirrored repositories can be found on mirror.b10c.me