- to be consistent and for better readability move all remaining SLOT()/SIGNAL() connections from .ui files into the .cpp files
Bitcoin-Qt: remove SLOT()/SIGNAL() connections from .ui files #2946
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:noConnectUIfiles changing 12 files +32 −188-
Diapolo commented at 12:49 PM on August 28, 2013: none
-
e4d48032cc
Bitcoin-Qt: remove SLOT()/SIGNAL() connections from .ui files
- to be consistent and for better readability move all remaining SLOT()/SIGNAL() connections from .ui files into the .cpp files
-
laanwj commented at 7:06 PM on August 28, 2013: member
Why? Wouldn't it be better to specify declaratively what can be specified declaratively?
-
Diapolo commented at 7:37 AM on August 29, 2013: none
@laanwj I don't like that we currently have mixed ways of using these Qt signal stuff. If we define "it's okay to use connections specified via the Qt Designer" that is fine with me, but then we should rework the code to move this into the .ui files.
Perhaps that would also remove some of the on_XYZ_clicked() stuff from our code, which Qt handles then declaratively :). What do you think?
-
laanwj commented at 11:07 AM on August 29, 2013: member
The on_XYZ_clicked stuff is generated by Qt creator as well, ie when you click on a widget and then add an event handler. In a way it is declarative, the name of the function declares what it should be bound to.
-
Diapolo commented at 1:19 PM on August 29, 2013: none
Wait :), I always manually added these on_XYZ_stuff ^^, didn't even know this can be achieved via Qt Creator ^^. Holy fuck...
Anyway, should we define devs have to use connections() via .ui files, if possible then?
-
laanwj commented at 2:06 PM on August 29, 2013: member
Sure... I don't really mind that much, devs can use them if convenient, no need to either forbid them or mandate them.
-
Diapolo commented at 2:16 PM on August 29, 2013: none
If you don't care, I have no chance forcing them :-P, so closed ^^.
- Diapolo closed this on Aug 29, 2013
- Diapolo deleted the branch on Aug 29, 2013
- Bushstar referenced this in commit fc73b4d6e6 on Apr 8, 2020
- DrahtBot locked this on Sep 8, 2021
