26.x: backport #28784 (“rpc: keep .cookie if it was not generated”) #29503

1. 
   darosior commented at 10:03 am on February 28, 2024: member

   v26 introduced a regression in that starting a bitcoind twice may have the second instance delete the cookie file of the first, making it impossible to communicate with it.

   Not a big deal but it’s annoying, only an issue for 26.0, and the patch is trivial.

2. 
   DrahtBot commented at 10:03 am on February 28, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	glozow

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Backport on Feb 28, 2024
4. 
   maflcko commented at 10:14 am on February 28, 2024: member

   The backport should include the metadata:

   0Github-Pull: #num
   1Rebased-From: commit_id
   

   You may use a script to do it for you: https://github.com/bitcoin-core/bitcoin-maintainer-tools#backport

5. maflcko added this to the milestone 26.1 on Feb 28, 2024
6. rpc: keep .cookie if it was not generated

   Otherwise, starting bitcoind twice may cause the `.cookie`
   file generated by the first instance to be deleted by the
   second instance shutdown (after failing to obtain a lock).
   
   Github-Pull: bitcoin/bitcoin#28784
   Rebased-From: 7cb9367157eb42ee06bc6fa024522cc14a80138d

   1e956439eb
7. darosior force-pushed on Feb 28, 2024
8. 
   darosior commented at 10:20 am on February 28, 2024: member

   Thanks, done using backport.py.
9. 
   glozow commented at 3:41 pm on February 28, 2024: member

   lgtm ACK 1e956439eb86de7a455560c349370684f4e54561
10. glozow merged this on Feb 28, 2024
11. glozow closed this on Feb 28, 2024

    ---

Contributors
darosior DrahtBot maflcko glozow

Labels
Backport

Milestone
26.1