Correctly use the purpose of addresses that are added after the start of the client. Addresses with purpose "refund" should not be visible in the GUI address list. This is handled correctly after this commit.
[Qt] Handle address purpose in incremental updates #2951
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_08_addressbook_purpose changing 7 files +54 −33-
laanwj commented at 2:26 PM on August 29, 2013: member
-
dcd0b0775e
qt: Handle address purpose in incremental updates
Correctly use the purpose of addresses that are added after the start of the client. Addresses with purpose "refund" and "change" should not be visible in the GUI. This is now handled correctly.
-
Diapolo commented at 3:01 PM on August 29, 2013: none
Was this necessary because of the payment-request pull? Code looks good (didn't try to compile), I'm just asking myself, what rule is used to indent over-lenght function calls :).
-
laanwj commented at 3:40 PM on August 29, 2013: member
Yes, it was introduced with payment requests.
No specific rule, but once lines get crazily wide I think it's a good idea to split them...
-
-
BitcoinPullTester commented at 2:38 PM on September 1, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/dcd0b0775ef63ac9e067d9eb67012332f1a72bd7 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
Diapolo commented at 9:58 PM on September 1, 2013: none
Compiles fine, code looks correct, no strange behaviour observed, so ACK!
- laanwj referenced this in commit 1537d174d7 on Sep 2, 2013
- laanwj merged this on Sep 2, 2013
- laanwj closed this on Sep 2, 2013
- laanwj deleted the branch on Apr 9, 2014
- Bushstar referenced this in commit b293e6ddee on Apr 8, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors