test: fix a race in rpc_net.py (wait for P2P handshake to complete) #29515

pull vasild wants to merge 1 commits into bitcoin:master from vasild:fix_race_in_rpc_net.py changing 1 files +5 −0

vasild commented at 11:12 AM on February 29, 2024: contributor
We connect a new peer, wait for it using self.nodes[0].wait_for_new_peer() and then demand that "transport_protocol_type" is either "v1" or "v2". However wait_for_new_peer() may return too early - during the P2P handshake when "transport_protocol_type" is "detecting".

Fix this by waiting for the P2P handshake to complete and the protocol version to be established.

An example failure (equal fields removed for clarity):
```
AssertionError: not({
    ...
    'session_id': '',
    'transport_protocol_type': 'detecting',
} == {
    ...
    'session_id': '8fe5902166b892a57ac6849caadd02d2dff83d84f2e57ee50bf894f93cf2f62e',
    'transport_protocol_type': 'v2',
})
```
https://cirrus-ci.com/task/5839860502626304?logs=ci#L8326

test: fix a race in rpc_net.py (wait for P2P handshake to complete)

We connect a new peer, wait for it using `self.nodes[0].wait_for_new_peer()`
and then demand that "transport_protocol_type" is either "v1" or "v2".
However `wait_for_new_peer()` may return too early - during the P2P handshake
when "transport_protocol_type" is "detecting".

Fix this by waiting for the P2P handshake to complete and the protocol
version to be established.

An example failure (equal fields removed for clarity):

```
AssertionError: not({
    ...
    'session_id': '',
    'transport_protocol_type': 'detecting',
} == {
    ...
    'session_id': '8fe5902166b892a57ac6849caadd02d2dff83d84f2e57ee50bf894f93cf2f62e',
    'transport_protocol_type': 'v2',
})
```

2052ad5fb3

DrahtBot commented at 11:23 AM on February 29, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
DrahtBot added the label Tests on Feb 29, 2024
maflcko commented at 11:27 AM on February 29, 2024: member

Generally, it is good to check the open pull requests before opening a pull request, to avoid duplicate patches for the same fix.
maflcko closed this on Feb 29, 2024
maflcko commented at 11:28 AM on February 29, 2024: member

https://github.com/bitcoin/bitcoin/pull/29511
vasild deleted the branch on Feb 29, 2024
bitcoin locked this on Feb 28, 2025

Contributors

Labels

test: fix a race in rpc_net.py (wait for P2P handshake to complete) #29515

Code Coverage

Reviews