ci: Functional tests for PRs in Windows GHA job stopped working #29534

1. 
   hebasto commented at 0:09 am on March 2, 2024: member

   During transition of the Windows runner image from version 20240122.1.0 to 20240128.1.0, the “Run functional tests” step in the “Win64 native” job stopped working for pull requests:

   0WARNING! Test '' not found in full test list.
   1No valid test scripts specified. Check that your test is in one of the test lists in test_runner.py, or run test_runner.py with no arguments to run all tests
   

   It seems, that the empty value of the TEST_RUNNER_EXTRA environment variable is not handled properly.

2. hebasto added the label Tests on Mar 2, 2024
3. fanquake closed this on Mar 5, 2024

   ---

4. fanquake referenced this in commit 0fa9f17332 on Mar 5, 2024
5. 
   hebasto commented at 6:53 pm on March 7, 2024: member

   Cross-posting from #29581 (comment):

   The breaking change was introduced in PowerShell 7.3:

   Windows and Linux/macOS have fundamental differences in how native command arguments are handled specifically when quotes are involved. We added a new feature $PSNativeCommandArgumentPassing to control how PowerShell passes arguments to native commands. The default behavior for Windows and Linux/macOS should work as most users expect in their respective environments.

   tl;dr: Empty strings are preserved as arguments now.

   The CI was broken due to the PowerShell upgrade from 7.2.18 to 7.4.1.

6. bitcoin locked this on Mar 7, 2025

Contributors
hebasto

Labels
Tests