Bitcoin-Qt: Use qDebug() for printing to debug.log #2973

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:qDebug changing 7 files +67 −52

Diapolo commented at 9:56 AM on September 4, 2013: none
- removes all usages of PrintDebugStringF from Qt code
- ensure same format for all debug.log messages "functionname() : Message"

Bitcoin-Qt: Use qDebug() for printing to debug.log

- removes all usages of PrintDebugStringF from Qt code
- ensure same format for all debug.log messages "functionname : Message"

42018eff07

in src/qt/paymentrequestplus.cpp:None in 4f3a628fde outdated

 178 | @@ -178,7 +179,7 @@ bool PaymentRequestPlus::getMerchant(X509_STORE* certStore, QString& merchant) c
 179 |      catch (SSLVerifyError& err)
 180 |      {
 181 |          fResult = false;
 182 | -        qDebug() << "PaymentRequestPlus::getMerchant SSL err: " << err.what();
 183 | +        qDebug() << "PaymentRequestPlus::getMerchant() : SSL error: " << err.what();

laanwj commented at 9:59 AM on September 5, 2013:

I wonder why you add () to the function names? In case of overloaded functions I guess it could make sense to add the argument types to the signature, but an empty () seems unnecessary.

Edit: btw you can use __func__ to get the current function name

Diapolo commented at 8:35 AM on September 6, 2013: none

@laanwj Alright, should be complete and I removed all () like you suggested. An additional idea now would be to send all these to our debug window, what do you think?
BitcoinPullTester commented at 9:57 AM on September 6, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/42018eff07d235930ca91fa9e76e7ac128183438 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 9d6b60cf50 on Sep 6, 2013
laanwj merged this on Sep 6, 2013
laanwj closed this on Sep 6, 2013
laanwj commented at 10:29 AM on September 6, 2013: member

I don't think it is useful to send all the logging to the debug window, I've thought about that in the beginning but we simply log so much for that it would bog down the GUI and it would not be useful either. At least with the current console widget. I guess it'd be possible to add a tab "logging" with a hyper-optimized scrolling widget, but I doubt it's worth the trouble and extra code.
Bushstar referenced this in commit bfcfb70d8c on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester