test: add V3 test case for inpool->inpackage->inpackage #29743

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:2024-03-v3-mixed-linear-case changing 1 files +10 −0

instagibbs commented at 9:38 PM on March 26, 2024: member

No description provided.
test: add V3 test case for inpool->inpackage->inpackage ceb0a4afd9
DrahtBot commented at 9:38 PM on March 26, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
DrahtBot added the label Tests on Mar 26, 2024
instagibbs commented at 9:38 PM on March 26, 2024: member

@glozow current coverage seems to cover inpackage->inpackage->inpackage, so this might be useful

in test/functional/mempool_accept_v3.py:276 in ceb0a4afd9

 271 | +
 272 | +        result = node.submitpackage([tx_v3_child["hex"], tx_v3_grandchild["hex"]])
 273 | +        assert_equal(result["package_msg"], f"v3-violation, tx {tx_v3_grandchild['txid']} (wtxid={tx_v3_grandchild['wtxid']}) would have too many ancestors")
 274 | +
 275 |      @cleanup(extra_args=["-acceptnonstdtxn=1"])
 276 |      def test_v3_ancestors_package_and_mempool(self):

tdb3 commented at 1:46 AM on March 27, 2024:

Is this scenario (parent is in mempool, child->grandchild package is submitted and is rejected) at least in part already covered in the test_v3_ancestors_package_and_mempool() test function? Maybe I'm overlooking something?

    def test_v3_ancestors_package_and_mempool(self):
        """
        A v3 transaction in a package cannot have 2 v3 parents.
        Test that if we have a transaction graph A -> B -> C, where A, B, C are
        all v3 transactions, that we cannot use submitpackage to get the
        transactions all into the mempool.

        Verify, in particular, that if A is already in the mempool, then
        submitpackage(B, C) will fail.
        """

instagibbs commented at 3:31 AM on March 27, 2024:

ya know what, it is. Closing this PR.

tdb3 commented at 1:47 AM on March 27, 2024: contributor

Always good to find new test coverage opportunities.
Pulled and ran functional test. Passed. Inline comment left.
instagibbs closed this on Mar 27, 2024
glozow commented at 9:56 AM on March 27, 2024: member

Agree this case is already covered. Though from offline conversation it sounds like you're hitting some interesting things when it's a package RBF, so will keep this case in mind. Thanks as well @tdb3 :)
bitcoin locked this on Mar 27, 2025

Contributors

Labels

test: add V3 test case for inpool->inpackage->inpackage #29743

Code Coverage

Reviews