26.x: backport #29853 (“sign: don’t assume we are parsing a sane Miniscript”) #29854

pull darosior wants to merge 1 commits into bitcoin:26.x from darosior:2404_ms_crash_backport_26 changing 2 files +25 −1
  1. darosior commented at 2:32 pm on April 11, 2024: member
    Backports #29853.
  2. sign: don't assume we are parsing a sane Miniscript
    The script provided for signature might be externally provided, for
    instance by way of 'finalizepsbt'. Therefore the script might be
    ill-crafted, so don't assume pubkeys are always 32 bytes.
    
    Thanks to Niklas for finding this.
    
    Github-Pull: bitcoin/bitcoin#29853
    Rebased-From: bdf2ef2c94cae2b0e2cdac1866322b4f9f7c7a7b
    be9802b237
  3. DrahtBot commented at 2:32 pm on April 11, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. DrahtBot added the label Backport on Apr 11, 2024
  5. glozow marked this as a draft on Apr 17, 2024
  6. glozow commented at 12:25 pm on April 17, 2024: member
    Thanks. Converted to draft until the PR for master is merged.
  7. glozow commented at 3:35 pm on May 13, 2024: member
    Commit needs to be updated. I can add this to #29899 (to include the release notes changes as well) and close this?
  8. glozow commented at 9:40 am on May 14, 2024: member
    @darosior I’ve added to #29899 so I’m closing this. Thanks!
  9. glozow closed this on May 14, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-21 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me