26.x: backport #29853 ("sign: don't assume we are parsing a sane Miniscript") #29854

pull darosior wants to merge 1 commits into bitcoin:26.x from darosior:2404_ms_crash_backport_26 changing 2 files +25 −1

darosior commented at 2:32 PM on April 11, 2024: member

Backports #29853.

sign: don't assume we are parsing a sane Miniscript

The script provided for signature might be externally provided, for
instance by way of 'finalizepsbt'. Therefore the script might be
ill-crafted, so don't assume pubkeys are always 32 bytes.

Thanks to Niklas for finding this.

Github-Pull: bitcoin/bitcoin#29853
Rebased-From: bdf2ef2c94cae2b0e2cdac1866322b4f9f7c7a7b

be9802b237

DrahtBot commented at 2:32 PM on April 11, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
DrahtBot added the label Backport on Apr 11, 2024
glozow marked this as a draft on Apr 17, 2024
glozow commented at 12:25 PM on April 17, 2024: member

Thanks. Converted to draft until the PR for master is merged.
glozow commented at 3:35 PM on May 13, 2024: member

Commit needs to be updated. I can add this to #29899 (to include the release notes changes as well) and close this?
glozow commented at 9:40 AM on May 14, 2024: member

@darosior I've added to #29899 so I'm closing this. Thanks!
glozow closed this on May 14, 2024
bitcoin locked this on May 14, 2025

Contributors

Labels

Linked (view graph)

#29853 sign: don't assume we are parsing a sane TapMiniscript

26.x: backport #29853 ("sign: don't assume we are parsing a sane Miniscript") #29854

Code Coverage

Reviews