- CreateTransaction will detect/report if txFee added was required or is voluntary
- Qt: different terms in send coins dialog
detect if txFee is voluntary #2987
pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:txfee changing 7 files +47 −16-
jonasschnelli commented at 6:34 PM on September 11, 2013: contributor
-
dab9fb41c7
detect if txFee is voluntary
- CreateTransaction will detect/report if txFee added was required or is voluntary - Qt: different terms in send coins dialog Signed-off-by: Jonas Schnelli <jonas.schnelli@include7.ch>
-
BitcoinPullTester commented at 7:11 PM on September 11, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/dab9fb41c7a4033b45c602840ee94b8039b6704b for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
gavinandresen commented at 10:49 PM on September 11, 2013: contributor
Related: I've been working on un-hardcoding fees, and part of that work is an 'estimatefees' RPC call.
I think that is really what people want to know, not after-the-fact whether or not the fee paid was 'voluntary' or 'mandatory'.
See my smartfee branch for details (but beware it is a work in progress, and will be constantly rebased): https://github.com/gavinandresen/bitcoin-git/tree/smartfee
-
jonasschnelli commented at 10:35 AM on September 12, 2013: contributor
Yes. estimatefee RPC call looks great (not checked in detail).
This pull does mostly change the QT behavior.
- create a transaction and "read out" if a fee was applied and if the fee was added because a voluntary fee was set or because the added fee was required.
- display the transaction (and info about if the fee was required or voluntary) to the user
- get yes/no from user
- commit transaction
-
gavinandresen commented at 2:29 AM on October 21, 2013: contributor
Needs rebase, although I'm not convinced this change is worth the cost of making all of our translators tweak all the language strings just to tell the user a piece of information that might be interesting but is not useful.
-
laanwj commented at 8:37 AM on November 10, 2013: member
Agreed with gavin here.
As the client currently has no way to compute or negotiate what is a required to get into a block, making a voluntary/required split in this way only adds to confusion.
We can update the GUI again after smart fees have been merged. What would be ideal is a user-settable transaction priority that is used to compute the fee, instead of a "voluntary" fee.
- gavinandresen closed this on Nov 11, 2013
- Bushstar referenced this in commit a363e5bf72 on Apr 8, 2020
- DrahtBot locked this on Sep 8, 2021
