test: add missing comparison of node1's mempool in MempoolPackagesTest #29941

pull Umiiii wants to merge 0 commits into bitcoin:master from Umiiii:master changing 0 files +0 −0

Umiiii commented at 1:44 PM on April 23, 2024: contributor

Add missing comparison for TODO comments in mempool_packages.py

Also, notice that the ancestor size limits and descendant size limits actually implemented in #21800 , so I removed the todo for those two size limits.
DrahtBot commented at 1:44 PM on April 23, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
DrahtBot added the label Tests on Apr 23, 2024
glozow commented at 1:56 PM on April 23, 2024: member

Thanks for the pull, please squash your commits
Umiiii force-pushed on Apr 23, 2024
Umiiii commented at 2:04 PM on April 23, 2024: contributor

Thanks for the pull, please squash your commits

squashed.
in test/functional/mempool_packages.py:202 in 2174ade2ef outdated
```
 204 | -        mempool = self.nodes[0].getrawmempool(True)
 205 | -        for tx in mempool:
 206 | -            assert_equal(mempool[tx]['unbroadcast'], False)
 207 | -
 208 | -        # TODO: test ancestor size limits
 209 | +        # Check more detailed check of node1's mempool
```
instagibbs commented at 2:36 PM on April 23, 2024:

these comments are not needed(and indented wrong); I think they can just all be removed since the test is self-explanatory

Umiiii commented at 1:39 AM on April 24, 2024:

Could you please clarify what you meant by "indented wrong"? I believe these lines are intended to follow the same indentation pattern as the rest of the file. If there's a specific indentation style that should be applied here, I'd appreciate your guidance.

Umiiii commented at 1:47 AM on April 24, 2024:

But I agreed with you. Those lines are self explanatory. I removed the comments.
Umiiii commented at 1:34 AM on April 24, 2024: contributor

@glozow could you review again and see if it meets the requirements now ..?
Umiiii force-pushed on Apr 24, 2024
Umiiii closed this on Apr 24, 2024
Umiiii force-pushed on Apr 24, 2024
achow101 referenced this in commit 7066980273 on May 10, 2024
PastaPastaPasta referenced this in commit 488ca8fcd7 on Oct 25, 2024
PastaPastaPasta referenced this in commit a0cd305a7c on Oct 26, 2024
bitcoin locked this on Apr 24, 2025

Contributors

Labels

Linked (view graph)

#21800 mempool/validation: mempool ancestor/descendant limits for packages #29948 test: add missing comparison of node1's mempool in MempoolPackagesTest

test: add missing comparison of node1's mempool in MempoolPackagesTest #29941

Code Coverage

Reviews