doc: Suggest only necessary Qt packages for installation on OpenBSD #29947

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240423-openbsd-qt-deps changing 1 files +2 −2
  1. hebasto commented at 10:57 pm on April 23, 2024: member

    The currently suggested qt5 installs many unneeded dependencies, for example, qtsensors, qtspeech etc.

    Similar to #29932.

  2. hebasto added the label Docs on Apr 23, 2024
  3. DrahtBot commented at 10:57 pm on April 23, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK theStack
    Concept ACK laanwj, vasild

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. hebasto commented at 10:57 pm on April 23, 2024: member
  5. theStack approved
  6. theStack commented at 11:41 pm on April 23, 2024: contributor

    Tested ACK b175ca9cc8bad4e106149260c3b592b1e0f2cb2f

    Verified on a fresh install of OpenBSD 7.5 that these two packages are the minimum requirement to build the GUI:

    • Without qtbase, the configure script invoked via ./configure --with-gui=qt5 MAKE=gmake fails with configure: error: Qt5Core >= 5.11.3 not found.
    • Without qttools, the configure script fails with configure: error: LRELEASE not found.
    • With both installed, the configure passes and the build succeeds.
  7. laanwj commented at 0:53 am on April 24, 2024: member
    Concept ACK. It’s nice that OpenBSD provides separate modules for Qt nowadays.
  8. maflcko commented at 6:05 am on April 24, 2024: member

    Verified on a fresh install of OpenBSD 7.5 that these two packages are the minimum requirement to build the GUI:

    Please update the version number in line 3 of the doc as well. I don’t know if there is a difference between 7.4 and 7.5, but it can’t hurt to be accurate here.

  9. doc: Suggest only necessary Qt packages for installation on OpenBSD
    The currently suggested `qt5` installs many unneeded dependencies, for
    example, `qtsensors`, `qtspeech` etc.
    970cbc3172
  10. hebasto force-pushed on Apr 24, 2024
  11. hebasto commented at 8:19 am on April 24, 2024: member

    Verified on a fresh install of OpenBSD 7.5 that these two packages are the minimum requirement to build the GUI:

    Please update the version number in line 3 of the doc as well. I don’t know if there is a difference between 7.4 and 7.5, but it can’t hurt to be accurate here.

    Sure. Updated.

  12. bitcoin deleted a comment on Apr 24, 2024
  13. vasild commented at 12:06 pm on April 24, 2024: contributor

    Concept ACK

    I have no (easy) way to verify that exactly those packages suffice, thus not full ACK.

  14. theStack approved
  15. theStack commented at 12:11 pm on April 24, 2024: contributor
    re-ACK 970cbc3172b73e1faf6bdb429400d3497cbb9d33
  16. DrahtBot requested review from laanwj on Apr 24, 2024
  17. DrahtBot requested review from vasild on Apr 24, 2024
  18. fanquake merged this on Apr 24, 2024
  19. fanquake closed this on Apr 24, 2024

  20. hebasto deleted the branch on Apr 24, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-01 10:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me