Bitcoin-Qt: BitcoinGUI::message() updates/fixes #2995

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:GUI_message changing 1 files +21 −14

Diapolo commented at 9:49 AM on September 14, 2013: none
- ensure message boxes are shown in center of our main window, not centered on the users desktop
- always prefer user supplied titles for message boxes over the functions defaults (fixes a bug, where transaction info messages did not contain information, if it was incoming or outgoing)

Bitcoin-Qt: BitcoinGUI::message() updates/fixes

- ensure message boxes are shown in center of our main window, not
  centered on the users desktop
- always prefer user supplied titles for message boxes over the functions
  defaults (fixes a bug, where transaction info messages did not contain
  information, if it was incoming or outgoing)

b26f9d893c

in src/qt/bitcoingui.cpp:None in ff96dfa1f6 outdated
```
 631 | @@ -625,7 +632,7 @@ void BitcoinGUI::message(const QString &title, const QString &message, unsigned
 632 |          if (!(buttons = (QMessageBox::StandardButton)(style & CClientUIInterface::BTN_MASK)))
 633 |              buttons = QMessageBox::Ok;
 634 |  
 635 | -        QMessageBox mBox((QMessageBox::Icon)nMBoxIcon, strTitle, message, buttons);
 636 | +        QMessageBox mBox((QMessageBox::Icon)nMBoxIcon, strTitle, message, buttons, (QMainWindow *)this);
```
laanwj commented at 12:20 PM on September 14, 2013:

Is the (QMainWindow*) needed here? I'd think it would do upcasting automatically.

Diapolo commented at 1:19 PM on September 14, 2013:

For messages, which are received from outside BitcoinGUI, it was not working as it should.

laanwj commented at 3:28 PM on September 14, 2013:

Yes, I agree that this extra parameter is a good idea. But I specifically mean that cast, won't just , this work just as well?

Diapolo commented at 4:05 PM on September 14, 2013:

Indeed just this does the job and I updated the pull.
BitcoinPullTester commented at 4:37 PM on September 14, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b26f9d893cb3b8b5ff74e7c71217181def1c2783 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 6:38 AM on September 21, 2013: member

ACK
laanwj referenced this in commit c2f4187263 on Sep 21, 2013
laanwj merged this on Sep 21, 2013
laanwj closed this on Sep 21, 2013
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester