Misbehaving peers never increase in ban score. #2997

Since at least the 8.x series, my "misbehaving" peers are never actively punished, even though there's log messages suggesting that they are.

ERROR: ProcessBlock() : already have block 257798 0000000000000023f4514ddd81a0a915bc16d59eaf9fe9a6e0344b1aa01319a3
Misbehaving: hostname.tld:8333 (0 -> 0)

The ban score always remains at 0, and is never increased for any peer, despite the many of messages saying that peers are misbehaving for a variety of reasons. Is this intended?

I could have sworn that previously, the score increased up until a threshold that would kick their connection, which never happens now. Nothing is strange about my configuration, it is a non-listening node in onion land running either the latest tagged build or the current master.

Some misbehaviour simply has score 0, for various reasons. I think the log message should just be made different in that case.

Agreed. These all get a little spammy after a while, and it looks out of place to have no score incremented for an offence.

ERROR: CTxMemPool::accept() : ConnectInputs failed d0b4b3abdd421a0bd288ae735d3389c4bb039249b1e958773aa2fb7f76fc793e
Misbehaving: ****:8333 (0 -> 0)

ERROR: ProcessBlock() : already have block 257797 000000000000000e0ba31f8dda53a8260d9fa3e2afe180636f6914d43335c0ac
Misbehaving: ****:8333 (0 -> 0)

ERROR: CTxMemPool::accept() : inputs already spent
Misbehaving: ****:8333 (0 -> 0)

@63 Should be fixed by #3047!

Did not go unnoticed @Diapolo, thanks.