test: Assumeutxo: ensure failure when importing a snapshot twice #29973

1. 
   alfonsoromanz commented at 1:34 pm on April 26, 2024: contributor

   I am getting familiar with the assume_utxo tests and I found that the scenario of trying to activate a snapshot twice is not covered. This test is to ensure failure when loading a snapshot if there is already a snapshot-based chainstate.
2. 
   DrahtBot commented at 1:34 pm on April 26, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fjahr, rkrux, kevkevinpal, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. 
   fjahr commented at 1:47 pm on April 26, 2024: contributor

   0test/functional/feature_assumeutxo.py:401:1: W293 blank line contains whitespace
   1^---- failure generated from lint-python.py
   

4. 
   fjahr commented at 1:47 pm on April 26, 2024: contributor

   Concept ACK
5. [Test] Assumeutxo: ensure failure when importing a snapshot twice b259b0e8d3
6. alfonsoromanz force-pushed on Apr 26, 2024
7. 
   DrahtBot commented at 1:51 pm on April 26, 2024: contributor

   🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.

   Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   Leave a comment here, if you need help tracking down a confusing failure.

   Debug: https://github.com/bitcoin/bitcoin/runs/24300439204

8. DrahtBot added the label CI failed on Apr 26, 2024
9. 
   alfonsoromanz commented at 1:54 pm on April 26, 2024: contributor

   0test/functional/feature_assumeutxo.py:401:1: W293 blank line contains whitespace
   1^---- failure generated from lint-python.py
   

   Thanks @fjahr. I just fixed the linting issue.

10. 
    fjahr commented at 2:36 pm on April 26, 2024: contributor

    Code review ACK b259b0e8d360726b062c4b0453d1cf5a68e1933f
11. alfonsoromanz renamed this:
    [Test] Assumeutxo: ensure failure when importing a snapshot twice
    test: Assumeutxo: ensure failure when importing a snapshot twice
    on Apr 26, 2024
12. DrahtBot removed the label CI failed on Apr 26, 2024
13. DrahtBot added the label Tests on Apr 26, 2024
14. in test/functional/feature_assumeutxo.py:398 in b259b0e8d3

    394@@ -395,6 +395,10 @@ def check_tx_counts(final: bool) -> None:
    395         assert_equal(snapshot['snapshot_blockhash'], dump_output['base_hash'])
    396         assert_equal(snapshot['validated'], False)
    397 
    398+        self.log.info("Check that loading the snapshot again will fail because there is already an active snapshot.")
    

    ---

    ---

    

    rkrux commented at 2:55 pm on May 8, 2024:

    I also tested with putting this block before the above for loop, and the tests passes. I wanted to see what would happen if we load another snapshot right after loading one.
15. rkrux approved
16. 
    rkrux commented at 2:55 pm on May 8, 2024: none

    tACK b259b0e

    Make successful, all functional tests pass. Short and to the point PR.

17. 
    kevkevinpal commented at 12:14 pm on May 9, 2024: contributor

    tACK b259b0e

    made a similar PR not knowing this existed https://github.com/bitcoin/bitcoin/pull/30068

18. 
    achow101 commented at 3:48 pm on May 9, 2024: member

    ACK b259b0e8d360726b062c4b0453d1cf5a68e1933f
19. achow101 merged this on May 9, 2024
20. achow101 closed this on May 9, 2024

    ---

Contributors
alfonsoromanz DrahtBot fjahr rkrux kevkevinpal achow101

Labels
Tests