test: remove duplicate WITNESS_SCALE_FACTOR constant definition #30029

1. 
   ismaelsadeeq commented at 9:36 am on May 3, 2024: member

   Notice this while working on #29523

   • blocktools.py and messages.py both define WITNESS_SCALE_FACTOR constant

   https://github.com/bitcoin/bitcoin/blob/99d7538cdb2a0ab7a7a2116cd5f33b95fc52b00e/test/functional/test_framework/blocktools.py#L48

   https://github.com/bitcoin/bitcoin/blob/99d7538cdb2a0ab7a7a2116cd5f33b95fc52b00e/test/functional/test_framework/messages.py#L68

   • This PR deletes the one in blocktools.py and update the tests to only use WITNESS_SCALE_FACTOR from messages.py
2. [test]: remove duplicate WITNESS_SCALE_FACTOR af3c18169a
3. 
   DrahtBot commented at 9:36 am on May 3, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, glozow, brunoerg, willcl-ark, sipa, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on May 3, 2024
5. 
   maflcko commented at 9:44 am on May 3, 2024: member

   ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
6. 
   glozow commented at 10:24 am on May 3, 2024: member

   lgtm ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
7. brunoerg approved
8. 
   brunoerg commented at 12:07 pm on May 3, 2024: contributor

   ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
9. willcl-ark approved
10. 
    willcl-ark commented at 3:19 pm on May 3, 2024: member

    ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
11. 
    sipa commented at 3:31 pm on May 3, 2024: member

    ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
12. 
    vostrnad commented at 4:10 pm on May 3, 2024: none

    nit: typo in PR name (defination -> definition)
13. ismaelsadeeq renamed this:
    test: remove duplicate `WITNESS_SCALE_FACTOR` constant defination
    test: remove duplicate `WITNESS_SCALE_FACTOR` constant definition
    on May 3, 2024
14. 
    achow101 commented at 4:35 pm on May 3, 2024: member

    ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
15. achow101 merged this on May 3, 2024
16. achow101 closed this on May 3, 2024

    ---

17. ismaelsadeeq deleted the branch on Jun 27, 2024

Contributors
ismaelsadeeq DrahtBot maflcko glozow brunoerg willcl-ark sipa vostrnad achow101

Labels
Tests