Using payment-request adds strange address to address book #3006

1. 
   Diapolo commented at 12:42 pm on September 17, 2013: none

   I’m using https://bitcoincore.org/~gavin/createpaymentrequest.php to test some GUI things with payment-requests and created one with a payment to address mfYEyfXvxhiRWyqmMUnVCTHrdjaCb5dvPn, which I have in my addressbock with label Gavin (AFAIK that one is one of his ^^).

   Now see what happens (only with secure payments):

   (before)

   (after)

2. 
   Diapolo commented at 12:56 pm on September 17, 2013: none

   This is from my debug.log:

3. 
   Diapolo commented at 1:12 pm on September 17, 2013: none

   It seems in WalletModel::SendCoinsReturn WalletModel::sendCoins(WalletModelTransaction &transaction) there is something happening, which causes this. I tried to output rcp.address and rcp.label to debug.log and both are plain emtpy.

   I debugged further and found out that this gets called (with empty or invalid parameters): https://github.com/bitcoin/bitcoin/blob/master/src/qt/walletmodel.cpp#L272

4. 
   luke-jr commented at 0:31 am on September 19, 2013: member

   I bet this is fixed with #1850 ? Maybe finally an easy test case for it…
5. 
   Diapolo commented at 8:45 am on October 4, 2013: none

   @laanwj This needs your help…
6. 
   laanwj commented at 11:44 am on October 7, 2013: member

   That’s a very strange address indeed. I’ve done the paymentrequests tests myself and did not encounter this. @diapolo Can you confirm or deny @luke-jr’s suspicion that this is solved with #1850? It could indeed have to do with a non-standard output somehow being converted to an (invalid, unlabaled) address.
7. 
   Diapolo commented at 11:57 am on October 7, 2013: none

   @laanwj I’m going to integrate @luke-jr’s patch, can you try to use the label, address and condition in my initial post to see if you can re-create the issue?
8. 
   Diapolo commented at 12:16 pm on October 7, 2013: none

   I included @luke-jr’s patch into my local build and still get the weird 3QJmnh address added to my addressbook. Perhaps it is important to mention that my testnet wallet is encrypted.

   Here is the link to the payment-request: https://bitcoincore.org/~gavin/createpaymentrequest.php?merchant=bitcoincore&address1=mfYEyfXvxhiRWyqmMUnVCTHrdjaCb5dvPn&amount1=0.001&address2=&amount2=&address3=&amount3=&time=0&expires=never&memo=My+Memo...&payment_url=on&ACK_message=Zahlung+erfolgreich%2C+danke!&produce_uri=on&submit=Create+Payment+Request

9. 
   Diapolo commented at 11:46 am on October 8, 2013: none

   @laanwj Alright, we HAVE a problem in void SendCoinsDialog::on_sendButton_clicked(), when we have a payment request, entry->getValue() has nothing in address or label, just amount and authenticatedMerchant are filled. We shouldn’t try to add anything to our addressbook, when we have a payment request IMHO?
10. laanwj closed this on Oct 16, 2013

    ---

11. MathyV referenced this in commit f889bde61f on Jun 20, 2014
12. MathyV referenced this in commit f457f653a7 on Jul 31, 2014
13. MathyV referenced this in commit 457548f98b on Jul 31, 2014
14. MathyV referenced this in commit 768dd7262b on Aug 3, 2014
15. MathyV referenced this in commit f5310243d7 on Aug 5, 2014
16. Bushstar referenced this in commit 780bffeb78 on Apr 8, 2020
17. MarcoFalke locked this on Sep 8, 2021

Contributors
Diapolo luke-jr laanwj