No description provided.
fix some printf -> LogPrintf leftovers #3020
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:LogPrint_fixes changing 3 files +6 −14-
Diapolo commented at 12:48 PM on September 19, 2013: none
-
jgarzik commented at 1:03 PM on September 19, 2013: contributor
I do not see any LogPrint() nor LogPrintf() in the tests... printf may be intentional.
-
Diapolo commented at 1:10 PM on September 19, 2013: none
Indeed, perhaps @sipa or @gavinandresen can comment. At least the comments and the change in wallet.cpp seems still be needed :).
-
gavinandresen commented at 6:58 AM on September 20, 2013: contributor
ACK on the wallet.cpp and main.cpp fixes.
Unit test should not LogPrint or printf at all, the test-runner gathers output.
-
BitcoinPullTester commented at 7:16 AM on September 20, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9a1b4b564a13f5d717538c89762e88b6eaf83525 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 7:37 AM on September 20, 2013: member
ACK after getting rid of the tests/ changes
-
fix some printf -> LogPrintf leftovers faaeae1eb3
-
Diapolo commented at 8:51 AM on September 20, 2013: none
Reverted the test changes... @gavinandresen I don't want to touch the tests, you are free to remove any output related stuff that shouldn't be in there.
-
sipa commented at 8:52 AM on September 20, 2013: member
ACK
- sipa referenced this in commit f676fb91f3 on Sep 20, 2013
- sipa merged this on Sep 20, 2013
- sipa closed this on Sep 20, 2013
- Bushstar referenced this in commit 2f21e55514 on Apr 8, 2020
- DrahtBot locked this on Sep 8, 2021
