refactor: remove unused CKey::Negate method #30218

1. 
   theStack commented at 3:08 pm on June 3, 2024: contributor

   This method was introduced as a pre-requirement for the v2 transport protocol back then (see PR #14047, commit 463921bb), when it was still BIP151. With the replacement BIP324, this is not needed anymore, and it’s also unlikely that for any other proposal we’d ever need to negate private keys at this abstraction level. I’d argue that this operation is usually something that should happen within a secp256k1 module (like e.g. done in MuSig2, Silent Payments…).

   (If there is really demand in the future, it’s also trivial to reintroduce the method.)

2. refactor: remove unused `CKey::Negate` method

   This method was introduced as a pre-requirement for the v2 transport
   protocol back then (see PR #14047, commit 463921bb), when it was still
   BIP151. With the replacement BIP324, this is not needed anymore, and
   it's also unlikely that any other proposal would need to negate private
   keys at this abstraction level.
   (If there is really demand, it's trivial to reintroduce the method.)

   8801e319d5
3. 
   DrahtBot commented at 3:08 pm on June 3, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	laanwj, sipa, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Refactoring on Jun 3, 2024
5. 
   laanwj commented at 4:01 pm on June 4, 2024: member

   ACK 8801e319d51209fe3a3b06e2aab5f96ceead290d There are no API consistency arguments to keep this, negating isn’t a conventional thing for keys.
6. 
   sipa commented at 4:10 pm on June 4, 2024: member

   ACK 8801e319d51209fe3a3b06e2aab5f96ceead290d
7. 
   achow101 commented at 1:29 am on June 5, 2024: member

   ACK 8801e319d51209fe3a3b06e2aab5f96ceead290d
8. achow101 merged this on Jun 5, 2024
9. achow101 closed this on Jun 5, 2024

   ---

10. theStack deleted the branch on Jun 5, 2024

Contributors
theStack DrahtBot laanwj sipa achow101

Labels
Refactoring