test: doc: fix units in tx-size standardness test (s/vbytes/weight units) #30254

1. 
   theStack commented at 12:04 pm on June 9, 2024: contributor

   This small fixup PR is a late follow-up for #17947 (commit 4537ba5f21ad8afb705325cd8e15dd43877eb28f), where the wrong units has been used in the comments for the large tx composition.
2. test: doc: fix units in tx size standardness test (s/vbytes/weight units) d1581c6048
3. 
   DrahtBot commented at 12:04 pm on June 9, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	tdb3, ismaelsadeeq, glozow

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Jun 9, 2024
5. tdb3 approved
6. 
   tdb3 commented at 12:53 pm on June 9, 2024: contributor

   ACK d1581c6048478cf70c5fb9ec5ebc178f16b376b8 Normally I would think this change could be included in a future change to test_IsStandard, but there is value in preventing confusion and not hoping that a future reviewer/author remembers to include this change.
7. in src/test/transaction_tests.cpp:909 in d1581c6048

   909-    //    1 output:              30 bytes =>    120 vbytes
   910-    //                      ===============================
   911-    //                                total: 400000 vbytes
   912+    // tx header:                12 bytes =>     48 weight units
   913+    // 2438 inputs: 2438*41 = 99958 bytes => 399832 weight units
   914+    //    1 output:              30 bytes =>    120 weight units
   

   ---

   ---

   

   ismaelsadeeq commented at 9:25 am on June 10, 2024:

   Are these bytes values vbytes?

   ---

   

   glozow commented at 9:37 am on June 10, 2024:

   Both AFAICT. Presumably the idea here is to show how weight units are calculated from bytes, so it doesn’t make much sense to start from vbytes.
8. 
   ismaelsadeeq commented at 9:25 am on June 10, 2024: member

   ACK d1581c6048478cf70c5fb9ec5ebc178f16b376b8

   C.I Failure is unrelated https://github.com/bitcoin/bitcoin/actions/runs/9436375635/job/25991001694?pr=30254

9. 
   glozow commented at 9:38 am on June 10, 2024: member

   ACK d1581c6048478cf70c5fb9ec5ebc178f16b376b8

   functional test CI failure looks unrelated

10. glozow removed the label Tests on Jun 11, 2024
11. glozow added the label Docs on Jun 11, 2024
12. glozow merged this on Jun 11, 2024
13. glozow closed this on Jun 11, 2024

    ---

14. theStack deleted the branch on Jun 11, 2024

Contributors
theStack DrahtBot tdb3 ismaelsadeeq glozow

Labels
Docs