test: add coverage for errors for combinerawtransaction #30264

1. 
   brunoerg commented at 6:20 pm on June 10, 2024: contributor

   This PR adds test coverage for the following errors for the combinerawtransaction RPC:

   • Tx decode failed
   • Missing transactions
   • Input not found or already spent

   For reference: https://maflcko.github.io/b-c-cov/total.coverage/src/rpc/rawtransaction.cpp.gcov.html

2. test: add coverage for errors for `combinerawtransaction` RPC

   * Tx decode failed
   * Missing transactions
   * Input not found or already spent

   ab98e6fd03
3. 
   DrahtBot commented at 6:20 pm on June 10, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, tdb3

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28710 (Remove the legacy wallet and BDB dependency by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Tests on Jun 10, 2024
5. 
   maflcko commented at 7:21 pm on June 10, 2024: member

   lgtm ACK ab98e6fd03970d6b5a593674c84e762a47b90ea6
6. tdb3 approved
7. 
   tdb3 commented at 2:08 pm on June 11, 2024: contributor

   ACK ab98e6fd03970d6b5a593674c84e762a47b90ea6 Thanks for adding coverage. The new asserts look like they fit in nicely with the existing test code. Ran rpc_transaction locally (passed).
8. fanquake merged this on Jun 11, 2024
9. fanquake closed this on Jun 11, 2024

   ---

Contributors
brunoerg DrahtBot maflcko tdb3

Labels
Tests