refactor: remove extraneous lock annotations from function definitions #30316

1. 
   theuni commented at 6:51 pm on June 20, 2024: member

   These annotations belong in the declarations rather than the definitions. While harmless now, future versions of clang may warn about these.

   Discovered these using the upstream WIP: https://github.com/llvm/llvm-project/pull/67520

2. refactor: remove extraneous lock annotations from function definitions

   These annotations belong in the declarations rather than the definitions.
   While harmless now, future versions of clang may warn about these.

   5729dbbb74
3. 
   DrahtBot commented at 6:51 pm on June 20, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	instagibbs, maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Refactoring on Jun 20, 2024
5. 
   theuni commented at 6:56 pm on June 20, 2024: member

   I should’ve mentioned in the description that all of these already have proper annotations in their corresponding declarations which is why they’re safe to remove. But reviewers should obviously double-check that.
6. 
   instagibbs commented at 8:03 pm on June 20, 2024: member

   ACK 5729dbbb7424d02c5e5bc4f2eb340fdc1c0100b4

   manually checked that all these annotations still live in the declarations

7. 
   maflcko commented at 8:18 am on June 21, 2024: member

   ACK 5729dbbb7424d02c5e5bc4f2eb340fdc1c0100b4 🦋

   Signature:

   0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
   1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
   2trusted comment: ACK 5729dbbb7424d02c5e5bc4f2eb340fdc1c0100b4 🦋
   3zGDwiYOysORatmPRkyxTlE8MYfUx4FBQyF1scw2iZzTkLsBw9dr84qXRJN1sH/zi6S3X/wAcRlNm5NSORToJBA==
   

8. fanquake merged this on Jun 21, 2024
9. fanquake closed this on Jun 21, 2024

   ---

Contributors
theuni DrahtBot instagibbs maflcko

Labels
Refactoring