scripted-diff: Log parameter interaction not thrice #30358

1. 
   maflcko commented at 3:47 pm on June 28, 2024: member

   Seems a bit overkill to log the words “parameter interaction” thrice, when at least once is enough. So do that.

   Before:

   02024-06-28T15:30:57Z [init.cpp:745] [InitParameterInteraction] InitParameterInteraction: parameter interaction: -connect or -maxconnections=0 set -> setting -dnsseed=0
   

   After:

   02024-06-28T15:47:27Z [init.cpp:745] [InitParameterInteraction] parameter interaction: -connect or -maxconnections=0 set -> setting -dnsseed=0
   

2. doc: Fix outdated dev comment about logging fafb7875e1
3. scripted-diff: Log parameter interaction not thrice

   -BEGIN VERIFY SCRIPT-
    sed -i 's/LogPrintf("%s: \(parameter interaction: .*\)", __func__/LogInfo("\1"/g' ./src/init.cpp
   -END VERIFY SCRIPT-

   fa1bc7c88b
4. 
   DrahtBot commented at 3:47 pm on June 28, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	paplorinc, TheCharlatan, fjahr, hodlinator

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #29641 (scripted-diff: Use LogInfo/LogDebug over LogPrintf/LogPrint by maflcko)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. DrahtBot renamed this:
   scripted-diff: Log parameter interaction not thrice
   scripted-diff: Log parameter interaction not thrice
   on Jun 28, 2024
6. DrahtBot added the label Refactoring on Jun 28, 2024
7. 
   paplorinc commented at 7:35 pm on June 28, 2024: contributor

   ACK fa1bc7c88bb720f02955dbe4e2a174b5a52f3af8
8. TheCharlatan approved
9. 
   TheCharlatan commented at 7:43 pm on June 28, 2024: contributor

   Nice, ACK fa1bc7c88bb720f02955dbe4e2a174b5a52f3af8
10. 
    fjahr commented at 8:04 pm on June 28, 2024: contributor

    utACK fa1bc7c88bb720f02955dbe4e2a174b5a52f3af8
11. hodlinator approved
12. 
    hodlinator commented at 10:00 pm on June 28, 2024: none

    utACK fa1bc7c88bb720f02955dbe4e2a174b5a52f3af8

    Should have already been made less repetitive when moving them into a dedicated function in 411b05ac9511395923976bfbd0c153ddabf2ebcf.

13. maflcko removed the label Refactoring on Jul 1, 2024
14. DrahtBot added the label Refactoring on Jul 1, 2024
15. maflcko removed the label Refactoring on Jul 1, 2024
16. maflcko added the label Utils/log/libs on Jul 1, 2024
17. fanquake merged this on Jul 1, 2024
18. fanquake closed this on Jul 1, 2024

    ---

19. maflcko deleted the branch on Jul 1, 2024

Contributors
maflcko DrahtBot paplorinc TheCharlatan fjahr hodlinator

Labels
Utils/log/libs