bitcoind shutdown code missing Boost thread join_all()? #3037

issue Diapolo opened this issue on September 27, 2013
  1. Diapolo commented at 5:05 PM on September 27, 2013: none

    I saw threadGroup.join_all(); in the Qt shutdown code and took a quick look at the bitcoind code, where this is missing in DetectShutdownThread() and before the end in AppInit(). @gavinandresen Can you take a look?

  2. Diapolo commented at 8:46 AM on October 4, 2013: none

    Anyone?

  3. gavinandresen commented at 5:02 AM on October 6, 2013: contributor

    I think you're correct, DetectShutdownThread should call join_all() after interrupt_all().

  4. gavinandresen closed this on Oct 7, 2013

  5. MathyV referenced this in commit 51f7281916 on Jun 20, 2014
  6. MathyV referenced this in commit 61755b9dbe on Jul 31, 2014
  7. MathyV referenced this in commit 229cfb3f71 on Jul 31, 2014
  8. MathyV referenced this in commit dc4a2d1cab on Aug 3, 2014
  9. MathyV referenced this in commit f0eec55d97 on Aug 5, 2014
  10. Bushstar referenced this in commit 02f6188e8f on Apr 8, 2020
  11. Bushstar referenced this in commit b1ffedb2dd on Apr 8, 2020
  12. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me