lint: Ignore files ignored by git in the Markdown Link Checker #30380

pull willcl-ark wants to merge 2 commits into bitcoin:master from willcl-ark:mlc-gitignore changing 2 files +3 −7
  1. willcl-ark commented at 8:49 AM on July 3, 2024: member

    Updating to MLC v0.18.0 includes a new feature which will ignore all files ignored by git: mlc --gitignore.

    This helps avoid false-positives flagged by this linter in non-project files, such as a developer might expect to have in their working directory (e.g. guix-builds, python venvs, etc.)

  2. lint: ignore files ignored by git in mlc
    Updating to MLC v0.18.0 includes a new feature which will ignore all
    files ignored by git: `--gitignore`.
    
    This helps avoid false-positives flagged by this linter in non-project
    files, such as a developer might expect to have in their directory (e.g.
    guix-builds, python venvs, etc.)
    4d942547a8
  3. DrahtBot commented at 8:49 AM on July 3, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. maflcko commented at 9:11 AM on July 3, 2024: member

    The lint suffix in the title should be a prefix :sweat_smile:

    lgtm otherwise

  5. maflcko approved
  6. lint: remove unneeded trailing line fix dea7afd5e4
  7. in test/lint/test_runner/src/main.rs:416 in 4d942547a8 outdated
     409 | @@ -410,6 +410,7 @@ fn lint_markdown() -> LintResult {
     410 |          "--offline",
     411 |          "--ignore-path",
     412 |          md_ignore_path_str.as_str(),
     413 | +        "--gitignore",
     414 |          "--root-dir",
     415 |          ".",
     416 |      ])
    


    maflcko commented at 9:14 AM on July 3, 2024:

    nit below: Can the // Filter out this annoying trailing line be removed now?


    willcl-ark commented at 10:15 AM on July 3, 2024:

    Yes, it looks like it can. Added a commit for that

  8. willcl-ark renamed this:
    Ignore files ignored by git in the Markdown Link Checker lint
    lint: Ignore files ignored by git in the Markdown Link Checker
    on Jul 3, 2024
  9. DrahtBot added the label Tests on Jul 3, 2024
  10. maflcko approved
  11. maflcko commented at 10:19 AM on July 3, 2024: member

    lgtm

  12. fanquake merged this on Jul 3, 2024
  13. fanquake closed this on Jul 3, 2024

  14. bitcoin locked this on Jul 3, 2025
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-27 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me