Fix gitian qt-win32.yml build #3043

pull wtogami wants to merge 1 commits into bitcoin:master from wtogami:fixqtwin32 changing 1 files +6 −6

wtogami commented at 3:31 AM on October 1, 2013: contributor

#3029 The final revision of PR 3029 incorporated a review suggestion of replacing i686-w64-mingw32 with $HOST. But we forgot that $HOST is not expanded when within single quotes so it actually broke qt-win32.yml build. Neither myself nor the reviewers caught this error. I take responsibility for this mistake.

This commit is the minimal necessary to restore the qt win32 build, similar to how it worked previously. I have personally tested rebuilding the entire stack from scratch and the result has a working deterministic bitcoin*.exe.

cfields has major cleanups for all gitian recipes coming soon, so please resist the urge to bikeshed this PR with more improvements as it is highly likely to be discarded in the coming rewrite.

Fix gitian qt-win32.yml build

The final revision of PR 3029 incorporated a review suggestion of replacing
i686-w64-mingw32 with $HOST. But we forgot that $HOST is not expanded when
within single quotes so it actually broke qt-win32.yml build.  This is the
minimal changes necessary to fix the qt-win32.yml build.

b5ab7f34f8

laanwj referenced this in commit bb3319f296 on Oct 1, 2013
laanwj merged this on Oct 1, 2013
laanwj closed this on Oct 1, 2013
Bushstar referenced this in commit 5bc53b6c26 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

wtogami

Linked (view graph)

#3029 Upgrade gitian win32 to Precise 12.04.