fix: rendering an amp characters in the wallet name for QMenu #30446

1. 
   knst commented at 6:24 am on July 13, 2024: none

   In the current implementation Qt uses ‘&’ as a signal to underscore letter and use it as a hot-key, which is not expected for case of wallet name.

   The comment in the code is misleading, if you replace one & to double &&, the next & will be a “single one”. All of them in the string should be replaced, not only the first occurrence.

   See screenshots before & after:

2. fix: correct replacement of amp character in the wallet name for QMenu

   The comment is missleading. If wallet name has & it is not supposed to use
   as a hot-key, but should be shown as it is without replacing to underscore

   948520b72d
3. 
   DrahtBot commented at 6:24 am on July 13, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. knst renamed this:
   fix: correct replacement of amp character in the wallet name for QMenu
   fix: rendering an amp characters in the wallet name for QMenu
   on Jul 13, 2024
5. 
   0xB10C commented at 11:37 am on July 13, 2024: contributor

   Thanks for the contribution knst. I think this PR might be better suited for https://github.com/bitcoin-core/gui. The gui repo is regularly synced with the bitcoin/bitcoin repo.
6. 
   hebasto commented at 11:47 am on July 13, 2024: member

   Thanks for the contribution knst. I think this PR might be better suited for https://github.com/bitcoin-core/gui. The gui repo is regularly synced with the bitcoin/bitcoin repo.

   Yes. @knst please close this PR and open it in https://github.com/bitcoin-core/gui.

7. hebasto added the label GUI on Jul 13, 2024
8. 
   knst commented at 12:32 pm on July 13, 2024: none

   closed as moved to bitcoin-core/gui: https://github.com/bitcoin-core/gui/pull/828
9. knst closed this on Jul 13, 2024

   ---

10. knst deleted the branch on Jul 13, 2024

Contributors
knst DrahtBot 0xB10C hebasto

Labels
GUI