depends: zmq: Fix Autotools-generated libzmq.pc file #30489

pull theuni wants to merge 7 commits into bitcoin:master from theuni:depends-zmq-patch changing 7 files +207 −12
  1. theuni commented at 6:10 pm on July 19, 2024: member

    Similar to #30488. Broken out of #30454. This is just taking the (merged) upstreamed PR: https://github.com/zeromq/libzmq/pull/4667

    On top of #29723 as that would otherwise conflict and is likely to be merged soon. I’ll rebase here and undraft after that’s merged.

    Like #30488, this may be obsoleted soon after switching to building with CMake because we’ll be able to use those files rather than pkg-config, but again it doesn’t hurt to have the fixed files.

  2. depends: add zeromq mktemp macos patch 2a10deb7d9
  3. depends: add zeromq builtin sha1 patch acd48880cc
  4. depends: add zeromq windows usage patch 6a2c2a3e48
  5. depends: add zeromq cmake minimum patch 02d74ce3fd
  6. depends: add zeromq no librt patch f6728be082
  7. depends: switch zmq to CMake
    The CMake WIN32_WINNT autodetection is broken, and must be set
    manually. We may want to set is explicitly in any case, but the
    brokenness should also be fixed upstream.
    
    Also patch out depends paths, that would cause non-determinism.
    
    Co-authored-by: fanquake <fanquake@gmail.com>
    b110e7ebfb
  8. depends: Fix Autotools-generated `libzmq.pc` file
    See https://github.com/zeromq/libzmq/pull/4667.
    
    Co-authored-by: Cory Fields <cory-nospam-@coryfields.com>
    44652afe7c
  9. DrahtBot commented at 6:10 pm on July 19, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  10. DrahtBot added the label Build system on Jul 19, 2024
  11. theuni commented at 6:12 pm on July 19, 2024: member
    Hah, I realized as soon as I hit the button that #29723 obsoletes this. Either the .pc is fine there, or it needs to be patched in a different place. Closing.
  12. theuni closed this on Jul 19, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-08 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me