lint: Add missing docker.io prefix to ci/lint_imagefile #30501

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2407-lint-fixes changing 2 files +2 −2
  1. maflcko commented at 3:32 pm on July 22, 2024: member

    Currently, the ci/lint_imagefile may pick the wrong (non-native) architecture due to the missing prefix.

    For example, assuming the user has previously pulled an s390x image:

    0$ podman run --rm 'docker.io/s390x/debian:bookworm' dpkg --print-architecture
    1exec /usr/bin/dpkg: exec format error
    

    Now, debian:bookworm will refer to the same image:

    0$ podman run --rm 'debian:bookworm' dpkg --print-architecture
    1exec /usr/bin/dpkg: exec format error
    

    However, docker.io/debian:bookworm works fine:

    0 $ podman run --rm 'docker.io/debian:bookworm' dpkg --print-architecture
    1arm64
    

    (Also includes a nit-fix from #30499 (review))

  2. lint: Add missing docker.io prefix to ci/lint_imagefile fadb7c2a91
  3. lint: Use git clone --depth=1
    No need to download and store more than that.
    fa7bee13bf
  4. DrahtBot commented at 3:32 pm on July 22, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK paplorinc, hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. DrahtBot renamed this:
    lint: Add missing docker.io prefix to ci/lint_imagefile
    lint: Add missing docker.io prefix to ci/lint_imagefile
    on Jul 22, 2024
  6. DrahtBot added the label Tests on Jul 22, 2024
  7. paplorinc approved
  8. paplorinc commented at 3:35 pm on July 22, 2024: contributor

    utACK fa7bee13bf745d8d244fa8d3579a21016a0cb66d

    Thanks!

  9. hebasto approved
  10. hebasto commented at 3:42 pm on July 22, 2024: member
    ACK fa7bee13bf745d8d244fa8d3579a21016a0cb66d.
  11. fanquake merged this on Jul 22, 2024
  12. fanquake closed this on Jul 22, 2024

  13. maflcko deleted the branch on Jul 23, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-08 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me