doc: Rename build notes for MinGW-w64 #30523

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240725-mingw-doc changing 5 files +4 −4
  1. hebasto commented at 9:58 am on July 25, 2024: member

    Broken out of #30454. Required because, after migration to CMake, the doc/ subdirectory will contain notes for both MinGW-w64 and MSVC.

    Addressed #30454 (review).

  2. DrahtBot commented at 9:58 am on July 25, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Docs on Jul 25, 2024
  4. hebasto force-pushed on Jul 25, 2024
  5. DrahtBot added the label CI failed on Jul 25, 2024
  6. DrahtBot commented at 10:05 am on July 25, 2024: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/27904920926

    Make sure to run all tests locally, according to the documentation.

    The failure may happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  7. in src/qt/README.md:7 in 62de945191 outdated
    3@@ -4,7 +4,7 @@ The current precise version for Qt 5 is specified in [qt.mk](/depends/packages/q
    4 
    5 ## Compile and run
    6 
    7-See build instructions: [Unix](/doc/build-unix.md), [macOS](/doc/build-osx.md), [Windows](/doc/build-windows.md), [FreeBSD](/doc/build-freebsd.md), [NetBSD](/doc/build-netbsd.md), [OpenBSD](/doc/build-openbsd.md)
    8+See build instructions: [Unix](/doc/build-unix.md), [macOS](/doc/build-osx.md), [Windows](/doc/build-windows-mingw.md), [FreeBSD](/doc/build-freebsd.md), [NetBSD](/doc/build-netbsd.md), [OpenBSD](/doc/build-openbsd.md)
    


    maflcko commented at 10:18 am on July 25, 2024:
    Isn’t this one and doc/README.md about native builds? So probably better to link to the msvc, but that seems unrelated, so anything is fine here.
  8. hebasto force-pushed on Jul 25, 2024
  9. maflcko commented at 10:21 am on July 25, 2024: member

    ACK 8ff05b6d96d89a9bac1c65b921b10f539048c61b

    Rename makes sense either way, to clarify that this is about cross-compilation and not about a native build.

  10. doc: Rename build notes for MinGW-w64 8ff05b6d96
  11. hebasto force-pushed on Jul 25, 2024
  12. hebasto commented at 10:27 am on July 25, 2024: member
    The CI lint task is green now. My apologies for multiple pushes.
  13. DrahtBot removed the label CI failed on Jul 25, 2024
  14. hebasto commented at 3:57 pm on July 25, 2024: member
    After a discussion on today’s CMake-WG call, closing in favour of https://github.com/hebasto/bitcoin/pull/284.
  15. hebasto closed this on Jul 25, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me