doc: rpc: Use “output script” consistently (2/2) #30524

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2407-rpc-doc-output-script changing 8 files +19 −19
  1. maflcko commented at 12:30 pm on July 25, 2024: member
    Small follow-up to #30408 to fixup the RPCs that were forgotten.
  2. DrahtBot commented at 12:30 pm on July 25, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK theStack

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Docs on Jul 25, 2024
  4. fanquake requested review from theStack on Jul 25, 2024
  5. theStack commented at 1:27 pm on July 25, 2024: contributor
    Thanks for following up. #30408 was specifically targeted at the “hex” and “asm” result fields, but of course it makes sense to fix the wording in other RPC doc places as well. git greping for \"scriptPubKey\" reveals that there are many more that aren’t tackled yet, especially for wallet-related RPCs: https://github.com/bitcoin/bitcoin/blob/5d280130446d57d653c749005a2e363265d87686/src/rpc/rawtransaction.cpp#L738 https://github.com/bitcoin/bitcoin/blob/5d280130446d57d653c749005a2e363265d87686/src/wallet/rpc/spend.cpp#L885 https://github.com/bitcoin/bitcoin/blob/5d280130446d57d653c749005a2e363265d87686/src/wallet/rpc/addresses.cpp#L531 https://github.com/bitcoin/bitcoin/blob/5d280130446d57d653c749005a2e363265d87686/src/wallet/rpc/coins.cpp#L533
  6. doc: rpc: Use "output script" consistently (2/2) fa5755b0a8
  7. maflcko force-pushed on Jul 25, 2024
  8. maflcko commented at 7:56 pm on July 25, 2024: member

    especially for wallet-related RPCs:

    I forgot them. Done all now.

  9. theStack approved
  10. theStack commented at 11:24 am on July 26, 2024: contributor
    lgtm ACK fa5755b0a8536b844fdccfecf386c1baab24f1c9
  11. fanquake merged this on Aug 12, 2024
  12. fanquake closed this on Aug 12, 2024

  13. maflcko deleted the branch on Aug 12, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me