Bump python minimum supported version to 3.10

maflcko commented at 7:26 pm on July 25, 2024: member

All supported operating systems ship with python 3.10 (or later), so bumping the minimum should not cause any issues. A bump will allow new code to use new python features.

For reference:

https://packages.debian.org/bookworm/python3
https://packages.ubuntu.com/jammy/python3
FreeBSD 13/14 ships with 3.11
CentOS-like 8/9 ships with 3.11/3.12 (via appstream)
OpenSuse Tumbleweed ships with all python versions, e.g. https://software.opensuse.org/package/python312-base

This is for Bitcoin Core 29.0 in 2025 (next year), not the soon upcoming 28.0 this fall.

DrahtBot commented at 7:26 pm on July 25, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	AngusP, l0rinc, stickies-v, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

maflcko added this to the milestone 29.0 on Jul 25, 2024

maflcko force-pushed on Jul 25, 2024

hebasto added the label Needs CMake port on Aug 16, 2024

maflcko marked this as ready for review on Aug 21, 2024

DrahtBot added the label Needs rebase on Aug 28, 2024

maflcko removed the label Needs CMake port on Aug 28, 2024

Bump python minimum supported version to 3.10 fa1b139d17

maflcko force-pushed on Aug 28, 2024

maflcko added the label DrahtBot Guix build requested on Aug 28, 2024

maflcko removed this from the milestone 29.0 on Aug 28, 2024

DrahtBot removed the label Needs rebase on Aug 28, 2024

hebasto commented at 10:31 am on August 29, 2024: member

All supported operating systems ship with python 3.10 (or later), so bumping the minimum should not cause any issues.

I agree on using newer tools.

A bump will allow new code to use new python features.

Out of curiosity, which features can you mention specifically?

maflcko commented at 10:34 am on August 29, 2024: member

In theory one could use the Python match, which was ported from Rust, IIRC.

Not sure if anyone wants to do that, or if it is worth it. Happy to close this pull instead and do a bump to 3.11 next year instead, which comes with more useful features.

DrahtBot commented at 9:05 pm on August 29, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 4ee1940e849efe8fb1510b11d78399231df4b578(master)	commit 323a12beaa560d481178880c64ace98b229787bf(master and this pull)
SHA256SUMS.part	`f3173a955837e725...`	`67be154c84724127...`
*-aarch64-linux-gnu-debug.tar.gz	`ca91ba66849cd58f...`	`773bdde82031de5f...`
*-aarch64-linux-gnu.tar.gz	`5f891b41807d5124...`	`c04afe0dadb84120...`
*-arm-linux-gnueabihf-debug.tar.gz	`5a7f53b22d19af93...`	`4a18218402bf858a...`
*-arm-linux-gnueabihf.tar.gz	`3cebdcfaab00b068...`	`8b6f6b391d1b15c5...`
*-arm64-apple-darwin-unsigned.tar.gz	`dbfb6b46a8ba5601...`	`ec5fbc84f7099b13...`
*-arm64-apple-darwin-unsigned.zip	`bbf23c3e0a6bb897...`	`c44198f8d24de6e5...`
*-arm64-apple-darwin.tar.gz	`fcf2ac36cb51fc58...`	`fd2d3edbbcfd3aff...`
*-powerpc64-linux-gnu-debug.tar.gz	`5384d0a1095cecac...`	`540b1a69e9e91353...`
*-powerpc64-linux-gnu.tar.gz	`0c1db8af0050158d...`	`6e7aed1b0351fc07...`
*-riscv64-linux-gnu-debug.tar.gz	`662af641aae75368...`	`59ac3d743dcd5952...`
*-riscv64-linux-gnu.tar.gz	`4a1d77dfe3bf89ea...`	`441be747cef91eae...`
*-x86_64-apple-darwin-unsigned.tar.gz	`60cf6ab775c9521a...`	`2da782e316bcbce3...`
*-x86_64-apple-darwin-unsigned.zip	`995e263afed6fad5...`	`7140ba0bf1e783fc...`
*-x86_64-apple-darwin.tar.gz	`71db56e0ac166e7b...`	`973d1610652abeb9...`
*-x86_64-linux-gnu-debug.tar.gz	`989ef754130c891f...`	`fa1983ae2eca40aa...`
*-x86_64-linux-gnu.tar.gz	`122343653b28d0df...`	`a24aa60da09af4d9...`
*.tar.gz	`2703b1ee9e245685...`	`7331b755b2c26fa1...`
guix_build.log	`e0e95dae7d26fe3d...`	`38ed8801d131550f...`
guix_build.log.diff		`0290ce2b6acc72b6...`

DrahtBot removed the label DrahtBot Guix build requested on Aug 29, 2024

AngusP approved

AngusP commented at 9:56 am on September 1, 2024: contributor

ACK fa1b139d17d04cb23bdfb1dd9c2abcdad4bdcd27

A few more:

Brew provides 3.9.19 thru 3.12.5 (with 3.8 as a deprecated package)
Fedora 40 ships 3.12.5
Alpine v3.20 ships 3.12.3
Arch ships 3.12.5

Zero-1729 commented at 1:19 pm on September 1, 2024: contributor

In theory one could use the Python match, which was ported from Rust, IIRC.

Not sure if anyone wants to do that, or if it is worth it. Happy to close this pull instead and do a bump to 3.11 next year instead, which comes with more useful features.

In that case, it might be worth just waiting to bump to 3.11 instead.

l0rinc approved

l0rinc commented at 1:56 pm on September 1, 2024: contributor

– Found Python3: /opt/homebrew/Frameworks/Python.framework/Versions/3.12/bin/python3.12 (found suitable version “3.12.5”, minimum required is “3.10”)

ACK fa1b139d17d04cb23bdfb1dd9c2abcdad4bdcd27

DrahtBot added the label CI failed on Sep 10, 2024

DrahtBot removed the label CI failed on Sep 13, 2024

DrahtBot added the label CI failed on Oct 13, 2024

achow101 requested review from Sjors on Oct 15, 2024

stickies-v approved

stickies-v commented at 4:08 pm on October 15, 2024: contributor

ACK fa1b139d17d04cb23bdfb1dd9c2abcdad4bdcd27

For reference: …

https://packages.ubuntu.com/jammy/python3

Note: focal is supported until April 2025 and ships with 3.8, but since that’s already unsupported as per our current 3.9 requirements that doesn’t really change anything.

maflcko added this to the milestone 29.0 on Oct 16, 2024

DrahtBot removed the label CI failed on Oct 16, 2024

achow101 commented at 12:21 pm on October 16, 2024: member

ACK fa1b139d17d04cb23bdfb1dd9c2abcdad4bdcd27

achow101 merged this on Oct 16, 2024

achow101 closed this on Oct 16, 2024

maflcko deleted the branch on Oct 16, 2024

Bump python minimum supported version to 3.10 #30527

Code Coverage

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]