test: MiniWallet tag_name issues #30528

1. 
   hodlinator commented at 8:06 am on July 26, 2024: contributor

   Is there an existing issue for this?

   • I have searched the existing issues

   Current behaviour

   @theStack introduced support for supplying a tag_name to the MiniWallet constructor in #29939.

   I was going to make a test use that feature, but uncovered the following issues.

   For some tag_names (like "12"), sendrawtransaction indirectly calls VerifyTaprootCommitment() which ends up calling secp256k1_xonly_pubkey_tweak_add_check() which ends up failing on the last condition - doing the parity check.

   There’s also an issue earlier during initialization on the Python side where tag_names like "12345" cause tweak_add_pubkey to return None, which leads to an exception.

   Expected behaviour

   Should support any tag_name value or document which ones are allowed.

   Steps to reproduce

   I’ve modified test/functional/feature_framework_miniwallet.py to expose issues I’ve encountered in 0ec889c5aee0a8aa03eac7380e39405eb0199edd.

   Relevant log output

   No response

   How did you obtain Bitcoin Core

   Compiled from source

   What version of Bitcoin Core are you using?

   master@5d280130446d57d653c749005a2e363265d87686

   Operating system and version

   NixOS (Linux)

   Machine specifications

   No response

2. 
   theStack commented at 8:26 am on July 26, 2024: contributor

   Thanks for your report! Both of your described issues are known and should be fixed with PR #30076. Can you test that branch and leave a review? Would be good if we get that in soon.
3. 
   hodlinator commented at 8:29 am on July 26, 2024: contributor

   Sorry about not finding that issue! Will test, thank you!
4. glozow closed this on Jul 26, 2024

   ---

5. fanquake referenced this in commit ec700f0a76 on Jul 26, 2024
6. bitcoin locked this on Jul 26, 2025

Contributors
hodlinator theStack