Fix spelling issues #30536
pull nnsW3 wants to merge 4 commits into bitcoin:master from nnsW3:fix-spelling-issues changing 2 files +2 −2-
nnsW3 commented at 8:18 am on July 27, 2024: noneHello I found several spelling issues in your docs. Glad I could help Br, Elias.
-
add missing verb assumeutxo.md 78c54bb148
-
fix spelling mempool-replacements.md 54e1a24eb0
-
remove extra word packages.md 9ecd12e644
-
DrahtBot commented at 8:18 am on July 27, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage
For detailed information about the code coverage, see the test coverage report.
Reviews
See the guideline for information on the review process.
Type Reviewers Concept NACK tdb3 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
tdb3 commented at 7:42 pm on July 27, 2024: contributor
NACK Thanks for taking a look. Typically, these types of basic changes are saved for when more impactful changes are made.
https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring
-
in doc/policy/mempool-replacements.md:68 in 9ecd12e644 outdated
64@@ -65,7 +65,7 @@ This set of rules is similar but distinct from BIP125. 65 66 ## History 67 68-* Opt-in full replace-by-fee (without inherited signaling) honoured in mempool and mining as of
paplorinc commented at 7:48 am on July 28, 2024:I’d revert this line, the docs and code sometimes use the British spelling, e.g. some funny ones like QColor warning_colourpaplorinc changes_requestedpaplorinc commented at 7:48 am on July 28, 2024: contributorThanksUpdate mempool-replacements.md c245f62e4epaplorinc commented at 5:15 pm on July 28, 2024: contributorTo set your expectations, this likely won’t be merged. But to maximize your chances, merge the commits.glozow commented at 10:57 am on July 29, 2024: memberThanks for your interest in contributing! However, as we have hundreds of pull requests, I am closing this to focus review on the others. (See contributing guidelines on refactoring).glozow closed this on Jul 29, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-29 18:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-29 18:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me