scriptpubkeyman fuzz target TopUp is slow (2/N) #30541

issue maflcko openend this issue on July 29, 2024
  1. maflcko commented at 8:10 am on July 29, 2024: member

    Follow-up to #30476

    Found by OSS-Fuzz / https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=70780

    Seems wasteful to spend time in TopUp while fuzzing, so my recommendation would be to limit TopUp iterations a bit.

    Context: clusterfuzz-testcase-scriptpubkeyman-5934021442338816.bin.txt

    0$ FUZZ=scriptpubkeyman perf record -g --call-graph dwarf  ./src/test/fuzz/fuzz -runs=1 ./clusterfuzz-testcase-scriptpubkeyman-5934021442338816.bin.txt
    1$ hotspot  ./perf.data 
    

    Screenshot from 2024-07-29 10-05-27

  2. maflcko added the label Wallet on Jul 29, 2024
  3. maflcko added the label Tests on Jul 29, 2024
  4. brunoerg commented at 5:16 pm on July 30, 2024: contributor
    I’m working on some improvements for this target. Reducing the keypool improves it but doesn’t solve the problem entirely.
  5. achow101 closed this on Aug 12, 2024

  6. Fabcien referenced this in commit 5c5a298f6d on Aug 12, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me