Fixes #29871
If addnode connections are made with v2transport and the peer immediately disconnects us, reconnections with v1 are scheduled. This could interfere with later checks depending on timing. Avoid this by using v2transport=False in the addnode rpc - this test isn’t about the message layer anyway, so running it with v2 would add no value.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
--v2transport multiple times (10) in case there was remaining intermittency (didn’t expect any since addnode calls are now v2transport=false). No failures encountered.
147@@ -148,7 +148,8 @@ def node_test(self, node, *, proxies, auth, test_onion, test_cjdns):
148 rv = []
149 addr = "15.61.23.23:1234"
150 self.log.debug(f"Test: outgoing IPv4 connection through node {node.index} for address {addr}")
151- node.addnode(addr, "onetry")
152+ # v2transport=False is used to avoid reconnections with v1 being scheduled. These could interfere with later checks.
153+ node.addnode(addr, "onetry", False)
0 node.addnode(addr, "onetry", v2transport=False)
Not sure about using integer and bool literals to call functions. It would be better to use named args. Otherwise, it is impossible to see the meaning of the literal from reading the line of code alone.
lgtm
Left a nit
If addnode connections are made with v2transport and the peer immediately disconnects us, reconnections
with v1 are scheduled. This could interfere with later checks depending on timing. Avoid this by using
`v2transport=False` in the addnode rpc - this test isn't about the message layer anyway, so running it
with v2 would add no value.