- The discussion of libbitcoinkernel has moved from 24303 to 27587
- Issue 15732 has been resolved, removing it from the document
doc: Update work in progress section in doc/design/libraries.md
#30547
pull
danielabrozzoni
wants to merge
2
commits into
bitcoin:master
from
danielabrozzoni:doc/kernel_202400730
changing
1
files
+1 −2
-
danielabrozzoni commented at 2:17 pm on July 30, 2024: contributor
-
doc: Update issue reference for libbitcoinkernel
The discussion of libbitcoinkernel has moved from #24303 to #27587, this commit updates the documentation accordingly.
-
DrahtBot commented at 2:17 pm on July 30, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage
For detailed information about the code coverage, see the test coverage report.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK TheCharlatan If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Docs on Jul 30, 2024
-
TheCharlatan approved
-
TheCharlatan commented at 2:32 pm on July 30, 2024: contributorACK b27ef8ec7f9a06318c7287e8cf245827a0731cc2
-
doc: Remove reference to resolved issue
Issue #15732 has been resolved, this commit removes it from the WIP section of the libraries document.
-
in doc/design/libraries.md:113 in b27ef8ec7f outdated
108@@ -109,5 +109,5 @@ class bitcoin-qt,bitcoind,bitcoin-cli,bitcoin-wallet bold 109 110 ## Work in progress 111 112-- Validation code is moving from *libbitcoin_node* to *libbitcoin_kernel* as part of [The libbitcoinkernel Project #24303](https://github.com/bitcoin/bitcoin/issues/24303) 113+- Validation code is moving from *libbitcoin_node* to *libbitcoin_kernel* as part of [The libbitcoinkernel Project #27587](https://github.com/bitcoin/bitcoin/issues/27587) 114 - Source code organization is discussed in general in [Library source code organization #15732](https://github.com/bitcoin/bitcoin/issues/15732)
maflcko commented at 2:32 pm on July 30, 2024:Not sure how much internal library design is left to be done here. Also, the other issue seems to be closed/resolved, so maybe this whole section can be removed? Obviously the library design isn’t final, and will change in the future, but I am not sure if the document is the right place to keep track of (and update with) all brainstorming issues about library build design.
TheCharlatan commented at 2:38 pm on July 30, 2024:The actual PR for getting the internal design w.r.t. kernel done is still waiting: #28690 (see my last comment there). I think it is fine to link the tracking issue to reduce confusion?
maflcko commented at 4:03 pm on July 30, 2024:Sure sounds good to keep the link to 27587/28690. I still think that the link to the closed 15732 can be removed, because any relevant details are inside this document already, but that can also be done in a follow-up.
danielabrozzoni commented at 12:25 pm on July 31, 2024:I didn’t notice, thanks! Pushed a commit to remove 15732.danielabrozzoni renamed this:
doc: Update issue reference for libbitcoinkernel
doc: Update work in progress section in `doc/design/libraries.md`
on Jul 31, 2024maflcko commented at 12:24 pm on July 31, 2024: memberACK f70eb0eeefcd69aa233af4259f42b85763b9ff9bfanquake merged this on Jul 31, 2024fanquake closed this on Jul 31, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 21:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 21:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me