release: Update translations for v28.0 soft translation string freeze

hebasto commented at 3:32 pm on July 30, 2024: member

Note: (possible) vandalism/damage has been prevented by reverting the deletion of bitcoin_af, bitcoin_es_MX, and bitcoin_ru translations.

Required to open Transifex translations for v28.0 as it’s scheduled in #29891.

The previous similar PR: #29397.

qt: Pull recent translations from Transifex

The diff is generated by executing the `update-translations.py` script.
Removals of translation files have been discarded.

31b33019b7

qt: Bump Transifex slug for 28.x e49d858aab

qt: Update translation source file

The diff is generated by executing `make -C src translate`.

be419674da

DrahtBot commented at 3:32 pm on July 30, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	stickies-v

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto commented at 3:34 pm on July 30, 2024: member

cc @stickies-v @pablomartin4btc @johnny9

hebasto added the label GUI on Jul 30, 2024

hebasto added this to the milestone 28.0 on Jul 30, 2024

stickies-v approved

stickies-v commented at 12:55 pm on August 1, 2024: contributor

ACK be419674da66e9c349c9c35246c20a7b9fda2dd0

It seems you’ve made some manual adjustments that might be worth documenting in the PR description? Specifically, I’ve noticed:

you’ve prevented (what appears to be) vandalism by reverting the deletion of bitcoin_af, bitcoin_es_MX, and bitcoin_ru translations
you’ve rolled back some clearly not Swedish translations in bitcoin_sv:

 0diff --git a/src/qt/locale/bitcoin_sv.ts b/src/qt/locale/bitcoin_sv.ts
 1index 618a3acbb0..e80f0b6380 100644
 2--- a/src/qt/locale/bitcoin_sv.ts
 3+++ b/src/qt/locale/bitcoin_sv.ts
 4@@ -341,36 +341,36 @@ Försök igen.</translation>
 5     <message numerus="yes">
 6         <source>%n second(s)</source>
 7         <translation type="unfinished">
 8-            <numerusform />
 9-            <numerusform />
10+            <numerusform>%n second(s)</numerusform>
11+            <numerusform>%n second(s)</numerusform>
12         </translation>
13     </message>
14     <message numerus="yes">
15         <source>%n minute(s)</source>
16         <translation type="unfinished">
17-            <numerusform />
18-            <numerusform />
19+            <numerusform>%n minute(s)</numerusform>
20+            <numerusform>%n minute(s)</numerusform>
21         </translation>
22     </message>
23     <message numerus="yes">
24         <source>%n hour(s)</source>
25         <translation type="unfinished">
26-            <numerusform />
27-            <numerusform />
28+            <numerusform>%n hour(s)</numerusform>
29+            <numerusform>%n hour(s)</numerusform>
30         </translation>
31     </message>
32     <message numerus="yes">
33         <source>%n day(s)</source>
34         <translation type="unfinished">
35-            <numerusform />
36-            <numerusform />
37+            <numerusform>%n day(s)</numerusform>
38+            <numerusform>%n day(s)</numerusform>
39         </translation>
40     </message>
41     <message numerus="yes">
42         <source>%n week(s)</source>
43         <translation type="unfinished">
44-            <numerusform />
45-            <numerusform />
46+            <numerusform>%n week(s)</numerusform>
47+            <numerusform>%n week(s)</numerusform>
48         </translation>
49     </message>
50     <message>
51@@ -380,8 +380,8 @@ Försök igen.</translation>
52     <message numerus="yes">
53         <source>%n year(s)</source>
54         <translation type="unfinished">
55-            <numerusform />
56-            <numerusform />
57+            <numerusform>%n year(s)</numerusform>
58+            <numerusform>%n year(s)</numerusform>
59         </translation>
60     </message>
61     </context>
62@@ -2840,8 +2840,8 @@ Om den här plånboken innehåller lösbara</translation>
63     <message numerus="yes">
64         <source>Estimated to begin confirmation within %n block(s).</source>
65         <translation type="unfinished">
66-            <numerusform />
67-            <numerusform />
68+            <numerusform>Estimated to begin confirmation within %n block(s).</numerusform>
69+            <numerusform>Estimated to begin confirmation within %n block(s).</numerusform>
70         </translation>
71     </message>
72     <message>
73@@ -3150,8 +3150,8 @@ Om den här plånboken innehåller lösbara</translation>
74     <message numerus="yes">
75         <source>matures in %n more block(s)</source>
76         <translation type="unfinished">
77-            <numerusform />
78-            <numerusform />
79+            <numerusform>matures in %n more block(s)</numerusform>
80+            <numerusform>matures in %n more block(s)</numerusform>
81         </translation>
82     </message>
83     <message>

Besides the diff outlined above, I’m getting the same output:

0../bitcoin-maintainer-tools/update-translations.py
1./configure && make -C src translate

Note:

bitcoin_az, bitcoin_az@latin, bitcoin_la seems to have a bunch of new English translations in it too

hebasto commented at 1:13 pm on August 1, 2024: member

you’ve prevented (what appears to be) vandalism by reverting the deletion of bitcoin_af, bitcoin_es_MX, and bitcoin_ru translations

It is mentioned in the commit message as “Removals of translation files have been discarded.”.

I’ll put your wording in the PR description.

hebasto commented at 3:12 pm on August 1, 2024: member

you’ve rolled back some clearly not Swedish translations in bitcoin_sv:

I haven’t. Those translations were updated by translators after I pulled the translations from the Transifex:

It’s a moving target, and we did our best in this PR.

hebasto merged this on Aug 1, 2024

hebasto closed this on Aug 1, 2024

pablomartin4btc commented at 5:55 pm on August 1, 2024: member

post-merge ACK be419674da66e9c349c9c35246c20a7b9fda2dd0

no diff

SamyDgz approved

release: Update translations for v28.0 soft translation string freeze #30548

Code Coverage

Reviews